Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

improvement: let docker do what tmux used to. and define gameserver as an environment variable. #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AvverbioPronome
Copy link

Hi, people. I guess there is no easy way to run the server in foreground other than debug mode, right?

However, I did this, and it probably no longer needs tmux. (I don't know LinuxGSM well enough and I only tested Quake2)

If there are nontrivial consequences from running a server permanently in debug mode, please tell me.

@AvverbioPronome AvverbioPronome changed the title let docker do what tmux used to. and define gameserver as an environment variable. improvement: let docker do what tmux used to. and define gameserver as an environment variable. Feb 16, 2020
@AvverbioPronome
Copy link
Author

I've been trying to go through lgsm's source to see if I could avoid the ugly hack "echo Y | ./gameserver debug" but I had no luck.

@dgibbs64
Copy link
Member

it could be possible to add either a new command or a setting to remove tmux ./csgoserver docker-start or somthing like that maybe?

@AvverbioPronome
Copy link
Author

I guess a command like ./csgoserver foreground could be more appropriate, but yeah, it makes sense.

@dgibbs64
Copy link
Member

dgibbs64 commented Feb 16, 2020

relevant https://github.com/GameServerManagers/LinuxGSM/pull/2026/files

GitHub
Docker support. Start game without tmux and game runs in foreground. Why without tmux? Hope it helps to push forward your docker repository.

@dgibbs64
Copy link
Member

dgibbs64 commented Feb 16, 2020

I am currently thinking about LinuxGSM commands as arguments might be implemented moving forward so the command might end up being ./csgoserver start --forground for example.

@dgibbs64
Copy link
Member

also to answer your question there are no issues running your server in debug mode apart from needing an active terminal which shouldn't be an issue in docker

@AvverbioPronome
Copy link
Author

I like this idea of using command arguments.

And yeah, in docker it is expected that applications run in foreground, and if they exit the container itself exits (and docker restarts it if the restart policy says so).

On another note: I am working on a separate branch to avoid installing every dependency for every server at once, it's a lot faster to bring up. :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants