Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

839 stacking layout config for tesseratos #1422

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jdbaracho
Copy link
Contributor

@jdbaracho jdbaracho commented Dec 21, 2024

Description

Include a summary of the changes here.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Add entry to the changelog's unreleased section.

@jdbaracho jdbaracho requested review from RiscadoA and a team as code owners December 21, 2024 20:16
@jdbaracho jdbaracho linked an issue Dec 21, 2024 that may be closed by this pull request
@jdbaracho jdbaracho requested review from SrGesus and removed request for a team December 21, 2024 20:16
@github-actions github-actions bot added A-Tesseratos B-ImGui B-Tools P-Urgent This issue is a big priority, and it would be good to close it ASAP labels Dec 21, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1422/
on branch gh-pages at 2024-12-21 20:18 UTC

@jdbaracho jdbaracho force-pushed the 839-stacking-layout-config-for-tesseratos branch from ee5a539 to 1157230 Compare December 21, 2024 20:21
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.42%. Comparing base (395ff0d) to head (4294088).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   53.42%   53.42%           
=======================================
  Files         462      462           
  Lines       25854    25854           
  Branches     2391     2391           
=======================================
  Hits        13813    13813           
  Misses      12041    12041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions[bot]

This comment was marked as resolved.

@jdbaracho jdbaracho enabled auto-merge (rebase) December 21, 2024 21:32
@jdbaracho jdbaracho self-assigned this Dec 21, 2024
Copy link

cubos-bot bot commented Dec 25, 2024

@RiscadoA will only be able to review this PR in 3 days.

1 similar comment
Copy link

cubos-bot bot commented Dec 30, 2024

@RiscadoA will only be able to review this PR in 3 days.

Copy link
Contributor

@SrGesus SrGesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for working on this! LGTM, but make sure to fix your commits before merging - merge commits aren't accepted on the main branch.
You can fix it by just running git fetch origin; git rebase origin/main I think.

Comment on lines +12 to +13
- Enable ImGui docking branch (#839, **@jdbaracho**).
- Enable ImGui docking on Tesseratos with a dockspace (#839, **@jdbaracho**).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can keep just the second one, the first one is implicit in the second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tesseratos B-ImGui B-Tools P-Urgent This issue is a big priority, and it would be good to close it ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ImGui docking branch on Tesseratos
3 participants