-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
839 stacking layout config for tesseratos #1422
base: main
Are you sure you want to change the base?
Conversation
|
ee5a539
to
1157230
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
Coverage 53.42% 53.42%
=======================================
Files 462 462
Lines 25854 25854
Branches 2391 2391
=======================================
Hits 13813 13813
Misses 12041 12041 ☔ View full report in Codecov by Sentry. |
…m:GameDevTecnico/cubos into 839-stacking-layout-config-for-tesseratos
@RiscadoA will only be able to review this PR in 3 days. |
1 similar comment
@RiscadoA will only be able to review this PR in 3 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for working on this! LGTM, but make sure to fix your commits before merging - merge commits aren't accepted on the main branch.
You can fix it by just running git fetch origin; git rebase origin/main
I think.
- Enable ImGui docking branch (#839, **@jdbaracho**). | ||
- Enable ImGui docking on Tesseratos with a dockspace (#839, **@jdbaracho**). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can keep just the second one, the first one is implicit in the second
Description
Include a summary of the changes here.
Checklist