Fix crash when using ImGui across DLL boundaries on Windows

[RiscadoA]

Description

You can read the documentation I included in the PR changes to understand what I'm fixing here.
If you're running Windows, previously with CUBOS_ENGINE_SHARED set to ON on CMake you probably got a crash on both Tesseratos and on the ImGui sample. With this change, that should no longer happen, so please test that before approving.

Checklist

• Self-review changes.
• Updated imgui plugin documentation.
• Update sample.
• Add entry to the changelog's unreleased section.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1376/
on branch gh-pages at 2024-11-30 08:27 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.92%. Comparing base (ddfe645) to head (d6e3f46).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
engine/src/imgui/plugin.cpp	0.00%	8 Missing ⚠️
engine/src/imgui/context.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   52.94%   52.92%   -0.02%     
==========================================
  Files         461      462       +1     
  Lines       26084    26090       +6     
  Branches     2419     2419              
==========================================
  Hits        13809    13809              
- Misses      12275    12281       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[diogomsmiranda]

If @SrGesus and @jdbaracho are Windows users then I don't mind looking at the code and review it, else I think we should assign Windows users as reviewers no? I have no machine to test this on.

@RiscadoA thoughts?

[diogomsmiranda]

LGTM!

[jdbaracho]

Is this about CUBOS_ENGINE_SHARED or BUILD_ENGINE_SHARED @RiscadoA ?

[RiscadoA]

Is this about CUBOS_ENGINE_SHARED or BUILD_ENGINE_SHARED @RiscadoA ?

The first one, the second one no longer exists, it was the old name of the same option which was renamed in a previous PR

[jdbaracho]

Tested on a Windows machine, at least the ImGUI sample and cubosurfers seem to run without any problems.
LGTM!