Implement spans for metrics profiling #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Core
B-Telemetry
S-Triage
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 40.20% 40.31% +0.11%
==========================================
Files 432 435 +3
Lines 30869 30908 +39
==========================================
+ Hits 12411 12462 +51
+ Misses 18458 18446 -12 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
fd5ab56
to
3933444
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
3933444
to
d8eba43
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
3 times, most recently
from
e6ad94e
to
5ff571e
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
4 times, most recently
from
8809e83
to
9a38bd9
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
9a38bd9
to
c3fff51
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
2 times, most recently
from
bc168d7
to
314df1f
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
314df1f
to
6664d07
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
0bee3c8
to
f966401
Compare
RiscadoA
requested changes
Sep 29, 2024
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
f966401
to
eae508b
Compare
diogomsmiranda
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I don't see much code of this part of CUBOS so can't be of much help, but looks like most of files changed were just refactor of the code to fit the new namespace. Found nothing very wrong when looking at the implementation and docs.
If all the other requested changes were already addressed then LGTM!
Very useful feature aswell!!
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
7 times, most recently
from
b8f4a46
to
174de77
Compare
Dageus
approved these changes
Oct 9, 2024
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
2 times, most recently
from
62242f8
to
7aa7c6c
Compare
roby2014
force-pushed
the
1265-implement-spans-for-metrics-+-profiling
branch
from
7aa7c6c
to
9189a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See linked issue for proposed implementation, but in short:
telwith metrics, tracing and logging.Checklist