-
Notifications
You must be signed in to change notification settings - Fork 35
Add nfc ui #488
base: main
Are you sure you want to change the base?
Add nfc ui #488
Conversation
Hi @kobieaw |
Hey @Extheoisah, |
Yeah. This works. However, i only see the ui changes you've made. Is the logic for the nfc still in progress? |
Yes, the bounty description just said to PR with the UI first. And in the description it said to do a different PR with the code implementation. Correct me if I'm wrong |
there is not much currently in this PR. the idea when we talk about the UI, is not to add just the button, but think about the overall experience, how things work when the payment is completed/pending/failed with NFC. do you haptic feedback, sound or something along those lines. but maybe that's easier to magic the logic altogether in this case @kobieaw |
btw, the svg has some text in it. I guess this is an oversight. |
Sounds good, yea I didn't know if you guys wanted all the other stuff like payment status and haptic feedback in the UI/UX PR or in logic. I'll update this PR. I'll also figure out how to get rid of the text at the bottom of the svg. |
Got the .svg out in a commit last week fyi. Fixed the issue with me not being able to test and now adding other stuff like payment status |
I added the .svg file and the button and image that has the "Read Card" text. Still need to add the business logic functionality. I also had pulled all of the other changes from the main branch. That will show up.