Skip to content

Commit

Permalink
fix: objects-list role name
Browse files Browse the repository at this point in the history
  • Loading branch information
bodymindarts committed May 25, 2022
1 parent 596f0a4 commit a8fa91f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion modules/inception/gcp/tf-state-bucket.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ resource "google_storage_bucket" "tf_state" {

resource "google_project_iam_custom_role" "list_objects" {
project = local.project
role_id = local.object_list_role_name
role_id = local.objects_list_role_name
title = "List bucket Objects"
description = "Role to _only_ list objects (not get them) from ${local.name_prefix}"
permissions = [
Expand Down
10 changes: 5 additions & 5 deletions modules/inception/gcp/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ variable "bastion_revoke_on_exit" {
variable "network_prefix" {
default = "10.0"
}
variable "object_list_role_name" {
default = "object-list"
variable "objects_list_role_name" {
default = "objects-list"
}

variable "inception_sa" {}
Expand Down Expand Up @@ -53,9 +53,9 @@ locals {
platform_admins = concat([for user in var.users : user.id if user.platform], ["serviceAccount:${var.inception_sa}"])
bastion_users = toset(concat([for user in var.users : user.id if user.bastion], local.platform_admins))

region = var.region
network_prefix = var.network_prefix
object_list_role_name = replace("${local.name_prefix}-${var.object_list_role_name}", "-", "_")
region = var.region
network_prefix = var.network_prefix
objects_list_role_name = replace("${local.name_prefix}-${var.objects_list_role_name}", "-", "_")

cluster_location = var.cluster_zone == "" ? local.region : "${local.region}-${var.cluster_zone}"
bastion_zone = "${local.region}-${var.primary_zone}"
Expand Down

0 comments on commit a8fa91f

Please sign in to comment.