fix: disable tracing in services testflight (#112)

* fix: move tf var into services.sh script * chore: remove quotes around boolean var
GaloyMoney · Dec 14, 2022 · 6ea964a · 6ea964a
1 parent d8d5c33
commit 6ea964a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/ci/gcp.lib.yml b/ci/gcp.lib.yml
@@ -51,8 +51,6 @@ KUBE_CA_CERT: #@ data.values.concourse_tf_kube_ca_cert
 KUBE_TOKEN: #@ data.values.concourse_tf_kube_token
 TF_VAR_gcp_project: galoy-infra-testflight
 TF_VAR_enable_services: false
-TF_VAR_enable_tracing: false
-
 BRANCH: #@ data.values.git_branch
 #@ end
 

diff --git a/ci/tasks/gcp/services.sh b/ci/tasks/gcp/services.sh
@@ -38,4 +38,4 @@ for i in {1..60}; do
 done
 set -e
 
-gcloud compute ssh --ssh-key-file=${CI_ROOT}/login.ssh ${bastion_name} --zone=${bastion_zone} -- "cd repo/examples/gcp; export GOOGLE_APPLICATION_CREDENTIALS=\$(pwd)/gcloud-creds.json; echo yes | make initial-services && echo yes | make services"
+gcloud compute ssh --ssh-key-file=${CI_ROOT}/login.ssh ${bastion_name} --zone=${bastion_zone} -- "cd repo/examples/gcp; export GOOGLE_APPLICATION_CREDENTIALS=\$(pwd)/gcloud-creds.json; export TF_VAR_enable_tracing=false; echo yes | make initial-services && echo yes | make services"
diff --git a/examples/gcp/services/main.tf b/examples/gcp/services/main.tf
@@ -6,7 +6,7 @@ variable "letsencrypt_issuer_email" {
 }
 
 variable "enable_tracing" {
-  default = "true"
+  default = true
 }
 
 data "google_client_config" "default" {

diff --git a/modules/services/variables.tf b/modules/services/variables.tf
@@ -17,7 +17,7 @@ variable "letsencrypt_issuer_email" {}
 variable "local_deploy" { default = false }
 variable "small_footprint" { default = false }
 variable "smoketest_cronjob" { default = false }
-variable "enable_tracing" { default = "true" }
+variable "enable_tracing" { default = true }
 
 locals {
   local_deploy             = var.local_deploy