-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): update mongodb default connection settings #4646
Changes from all commits
6fa3c9c
7e705e7
f524b20
35538dc
23703b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -312,12 +312,9 @@ export const LedgerService = (): ILedgerService => { | |
): Promise<Satoshis | LedgerError> => { | ||
const liabilitiesWalletId = toLiabilitiesWalletId(walletId) | ||
try { | ||
const { balance } = await MainBook.balance( | ||
{ | ||
account: liabilitiesWalletId, | ||
}, | ||
{ readPreference: "primaryPreferred" }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now it is not required because readPreference default value is primaryPreferred |
||
) | ||
const { balance } = await MainBook.balance({ | ||
account: liabilitiesWalletId, | ||
}) | ||
if (balance < 0) { | ||
const dealerUsdWalletId = await caching.getDealerUsdWalletId() | ||
const dealerBtcWalletId = await caching.getDealerBtcWalletId() | ||
|
@@ -343,12 +340,9 @@ export const LedgerService = (): ILedgerService => { | |
): Promise<BalanceAmount<S> | LedgerError> => { | ||
const liabilitiesWalletId = toLiabilitiesWalletId(walletDescriptor.id) | ||
try { | ||
const { balance } = await MainBook.balance( | ||
{ | ||
account: liabilitiesWalletId, | ||
}, | ||
{ readPreference: "primaryPreferred" }, | ||
) | ||
const { balance } = await MainBook.balance({ | ||
account: liabilitiesWalletId, | ||
}) | ||
if (balance < 0) { | ||
const dealerWalletIds = Object.values(await caching.getDealerWalletIds()) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,36 @@ import { WalletCurrency } from "@/domain/shared" | |
import { lazyLoadLedgerAdmin } from "@/services/ledger" | ||
import { WalletsRepository } from "@/services/mongoose" | ||
|
||
type SetupMongoConnectionArgs = { | ||
syncIndexes: boolean | ||
options?: mongoose.ConnectOptions | ||
} | ||
|
||
const DEFAULT_MONGODB_OPTIONS: mongoose.ConnectOptions = { | ||
autoIndex: false, | ||
compressors: ["snappy", "zlib"], | ||
|
||
maxPoolSize: 100, | ||
minPoolSize: 15, | ||
maxConnecting: 5, // Maximum number of concurrent connection attempts | ||
|
||
socketTimeoutMS: 60000, // Close sockets after 60 seconds of inactivity | ||
connectTimeoutMS: 15000, // Give up initial connection after 15 seconds | ||
serverSelectionTimeoutMS: 15000, // Keep trying to send operations for 15 seconds | ||
|
||
retryWrites: true, | ||
writeConcern: { | ||
w: "majority", // Wait for majority acknowledgment | ||
j: true, // Wait for journal commit | ||
wtimeout: 10000, // Write timeout | ||
}, | ||
|
||
retryReads: true, | ||
maxStalenessSeconds: 90, | ||
readPreference: "primaryPreferred", // Prefer primary but allow secondary reads | ||
readConcern: { level: "majority" }, // Read from majority-committed data | ||
} as const | ||
Comment on lines
+25
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Compared the defaults there is compression introduced and more connections with bigger pool sizes, these settings expected to increase the performance. Then in writeConcern and readConcern these settings should improve the consistency, hopefully not with too much tradeoff in performance. |
||
|
||
export const ledgerAdmin = lazyLoadLedgerAdmin({ | ||
bankOwnerWalletResolver: async () => { | ||
const result = await Account.findOne({ role: "bankowner" }, { defaultWalletId: 1 }) | ||
|
@@ -63,9 +93,11 @@ export const ledgerAdmin = lazyLoadLedgerAdmin({ | |
// TODO add an event listenever if we got disconnecter from MongoDb | ||
// after a first successful connection | ||
|
||
export const setupMongoConnection = async (syncIndexes = false) => { | ||
export const setupMongoConnection = async ( | ||
{ syncIndexes, options }: SetupMongoConnectionArgs = { syncIndexes: false }, | ||
) => { | ||
try { | ||
await mongoose.connect(MONGODB_CON, { autoIndex: false }) | ||
await mongoose.connect(MONGODB_CON, { ...DEFAULT_MONGODB_OPTIONS, ...options }) | ||
} catch (err) { | ||
baseLogger.fatal(`error connecting to mongodb`) | ||
throw err | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it is not required because readPreference is setup at server level