Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add email client #4002

Merged
merged 17 commits into from
Feb 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a906fae
feat(notifications): boilerplate for email client
thevaibhav-dixit Feb 15, 2024
a6b2ccd
chore(deps): add openssl to flake.nix
thevaibhav-dixit Feb 15, 2024
283e570
chore(notifications): some more boilerplate
thevaibhav-dixit Feb 15, 2024
9ae5995
chore(notifications): remove option on EMAIL_PASSWORD
thevaibhav-dixit Feb 15, 2024
0a97039
chore(notifications): remove dependency on openssl
thevaibhav-dixit Feb 15, 2024
169269f
chore(notifications): add Email as new notification channel
thevaibhav-dixit Feb 15, 2024
875971e
chore(notifications): rename lettre to smtp
thevaibhav-dixit Feb 15, 2024
45909ba
chore(notifications): remove Email from UserNotificationChannel
thevaibhav-dixit Feb 15, 2024
26c975a
chore(notifications): pass email_executor config in notifications.yml
thevaibhav-dixit Feb 16, 2024
244c106
chore(notifications): remove password from notifications.yml
thevaibhav-dixit Feb 16, 2024
0816c57
chore(notifications): complete the logic for sending email
thevaibhav-dixit Feb 18, 2024
216d215
chore(notifications): rename executor -> push_executor in app config
thevaibhav-dixit Feb 19, 2024
9d6313c
chore(notifications): provide default value of EMAIL_PASSWORD
thevaibhav-dixit Feb 19, 2024
5cc1373
chore(notifications): fix deps
UncleSamtoshi Feb 19, 2024
32b9f41
chore(notifications): do not send emails
UncleSamtoshi Feb 19, 2024
fb853aa
chore(notifications): rename messages
UncleSamtoshi Feb 19, 2024
2992369
chore(notifications): add LocalizedEmail
UncleSamtoshi Feb 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(notifications): provide default value of EMAIL_PASSWORD
  • Loading branch information
thevaibhav-dixit authored and UncleSamtoshi committed Feb 19, 2024
commit 9d6313cd21c287f24feb2e622b8907716fb5613d
2 changes: 1 addition & 1 deletion core/notifications/src/cli/config.rs
Original file line number Diff line number Diff line change
@@ -42,8 +42,8 @@ impl Config {
path: Option<impl AsRef<Path>>,
EnvOverride {
db_con,
kratos_pg_con,
email_password,
kratos_pg_con,
}: EnvOverride,
) -> anyhow::Result<Self> {
let mut config: Config = if let Some(path) = path {
6 changes: 3 additions & 3 deletions core/notifications/src/cli/mod.rs
Original file line number Diff line number Diff line change
@@ -14,10 +14,10 @@ struct Cli {
config: Option<PathBuf>,
#[clap(env = "PG_CON")]
pg_con: String,
#[clap(env = "EMAIL_PASSWORD", default_value = "password")]
email_password: String,
#[clap(env = "KRATOS_PG_CON")]
kratos_pg_con: Option<String>,
#[clap(env = "EMAIL_PASSWORD")]
email_password: String,
}

pub async fn run() -> anyhow::Result<()> {
@@ -27,8 +27,8 @@ pub async fn run() -> anyhow::Result<()> {
cli.config,
EnvOverride {
db_con: cli.pg_con,
kratos_pg_con: cli.kratos_pg_con,
email_password: cli.email_password,
kratos_pg_con: cli.kratos_pg_con,
},
)?;