Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default wallet field #3697

Merged
merged 4 commits into from
Dec 12, 2023
Merged

feat: add default wallet field #3697

merged 4 commits into from
Dec 12, 2023

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Dec 12, 2023

Description

This is to support being able to get details like an account's default wallet's currency without having to do multiple round trips

@github-actions github-actions bot added the core label Dec 12, 2023
@vindard vindard force-pushed the add-default-wallet-field branch 2 times, most recently from 4f144f9 to 4bb75a1 Compare December 12, 2023 15:26
@vindard vindard force-pushed the add-default-wallet-field branch from 4bb75a1 to e26e5b5 Compare December 12, 2023 15:51
Copy link
Collaborator

@dolcalmi dolcalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just minor change... also I think is better to have another review because it is an API change

@nicolasburtey
Copy link
Member

great idea. it would actually remove many lines of code in the mobile repo!

@vindard vindard force-pushed the add-default-wallet-field branch from 2018388 to 6eea181 Compare December 12, 2023 16:43
@vindard vindard merged commit 23a46db into main Dec 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants