Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dashboard to tilt #3431

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/buck2-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
cat <<EOF > labels.json
${{ toJSON(github.event.pull_request.labels.*.name) }}
EOF
for LABEL in $(jq -r '.[]' < labels.json); do
for LABEL in dashboard consent core; do
case "$LABEL" in
dashboard|consent)
ARGS+=" //apps/$LABEL:$LABEL"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/buck2-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
cat <<EOF > labels.json
${{ toJSON(github.event.pull_request.labels.*.name) }}
EOF
for LABEL in $(jq -r '.[]' < labels.json); do
for LABEL in dashboard consent core; do
case "$LABEL" in
dashboard|consent)
ARGS+=" //apps/$LABEL:test-unit"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tilt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
cat <<EOF > labels.json
${{ toJSON(github.event.pull_request.labels.*.name) }}
EOF
for LABEL in $(jq -r '.[]' < labels.json); do
for LABEL in dashboard consent core; do
case "$LABEL" in
dashboard|consent)
ARGS+=" --test $LABEL"
Expand Down
9 changes: 7 additions & 2 deletions apps/consent/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ dev_pnpm_task_binary(
command = "dev",
)

dev_pnpm_task_binary(
name = "lint-fix",
command = "lint:fix",
)

dev_pnpm_task_binary(
name = "open-cypress",
command = "cypress:open",
Expand Down Expand Up @@ -60,7 +65,7 @@ dev_deps_srcs = {
}

eslint(
name = "check-lint",
name = "lint",
srcs = [":src"] + glob([".eslint*"]),
extensions = [".ts", ".tsx"],
allow_warnings = True,
Expand All @@ -70,6 +75,6 @@ eslint(
test_suite(
name = "test-unit",
tests = [
":check-lint",
":lint",
],
)
4 changes: 2 additions & 2 deletions apps/consent/app/login/phone/server-actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ export const sendPhoneCode = async (
value: phone,
remember: remember,
}),
{ secure: true, sameSite: "lax" }
);
{ secure: true, sameSite: "lax" },
)

const params = new URLSearchParams({
login_challenge,
Expand Down
2 changes: 1 addition & 1 deletion apps/consent/cypress/support/test-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ export const testData = {
AUTHORIZATION_URL: Cypress.env("AUTHORIZATION_URL"),
PHONE_NUMBER: "+16505554350",
VERIFICATION_CODE: "000000",
EMAIL: "test@galoy.com",
EMAIL: "test@galoy.io",
}
18 changes: 0 additions & 18 deletions apps/consent/dev/get-url.sh

This file was deleted.

40 changes: 0 additions & 40 deletions apps/consent/dev/setup-user.sh

This file was deleted.

5 changes: 0 additions & 5 deletions apps/consent/makefile

This file was deleted.

Loading
Loading