feat: enable quiz completion without reward

[UncleSamtoshi]

• add quizRewardsEnabled to ConsumerAccount gql object
• enable marking a quiz question complete without payment success
• refactor PartialReturn type

[vindard]

One comment so far on the way we've implemented passing a result + error along

[vindard]

Looks good to me. Only comment left is, I wonder if it'll be easy to add a bats test for this

[dolcalmi]

this PR should only include changes related rewards, why is this an error?

[UncleSamtoshi]

This just matches the existing behavior, but with different types. As you can see in line 193 if there was any error, even if it was a partial success, we still threw in line 194.

[dolcalmi]

if this use PartialResult then should use the new approach

[UncleSamtoshi]

I will switch to using type on the partial result.

[UncleSamtoshi]

Looks good to me. Only comment left is, I wonder if it'll be easy to add a bats test for this

For testing we could add the unhappy path where the phone carrier is not supported. However I dont think we can get the local setup into a state where phone carrier and ip are valid.

[UncleSamtoshi]

One concern I have with this PR is we lose explicitly visibility into whether we actually paid out the reward. Previously the presence of a completed question implied that the reward was paid. However this introduces the possibility that a question is completed but a reward was not paid. Since this is a marketing feature it may not be critical to have this visibility. Additionally we could look through the ledger for a transaction correlating to that id.

In exchange for losing this visibility we now allow people without the ability to earn rewards the ability to still complete the earn section.

[nicolasburtey]

One concern I have with this PR is we lose explicitly visibility into whether we actually paid out the reward. Previously the presence of a completed question implied that the reward was paid. However this introduces the possibility that a question is completed but a reward was not paid. Since this is a marketing feature it may not be critical to have this visibility. Additionally we could look through the ledger for a transaction correlating to that id.

In exchange for losing this visibility we now allow people without the ability to earn rewards the ability to still complete the earn section.

we should make sure that we can, through tracing, plot the query where rewards are given or not.

[UncleSamtoshi]

we should make sure that we can, through tracing, plot the query where rewards are given or not.

This should be visible.

[vindard]

However this introduces the possibility that a question is completed but a reward was not paid.

Should we consider adding rewardPaid to persistence as well?