Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding otel in consent #3417

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat: adding otel in consent #3417

merged 3 commits into from
Oct 27, 2023

Conversation

siddhart1o1
Copy link
Member

No description provided.

apps/consent/env.ts Outdated Show resolved Hide resolved
@nicolasburtey
Copy link
Member

still erroring @siddhart1o1

@siddhart1o1 siddhart1o1 enabled auto-merge (squash) October 25, 2023 17:59
@siddhart1o1
Copy link
Member Author

still erroring @siddhart1o1

Not sure what's wrong as I am not getting any errors locally. Also, I haven't made changes in the dashboard until commit b0c924d, and am getting an error in this commit whereas the commit before this was passing.
and getting this error

 [2023-10-25T09:55:36.331+00:00] /home/runner/work/galoy/galoy/buck-out/v2/gen/root/524f8da68ea2a374/apps/dashboard/__check-lint__/__workspace/apps/dashboard/services/graphql/index.ts
[2023-10-25T09:55:36.331+00:00]   4:1  error  There should be at least one empty line between import groups  import/order

@siddhart1o1 siddhart1o1 force-pushed the feat--adding-otel-in-consent branch from b857342 to c75f3a2 Compare October 26, 2023 13:22
@siddhart1o1 siddhart1o1 merged commit adc1aff into main Oct 27, 2023
17 checks passed
siddhart1o1 added a commit that referenced this pull request Oct 28, 2023
* feat: adding otel in consent

* chore: addressing comments

* fix: lint errors

---------

Co-authored-by: Siddharth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants