test(core): move 'accounts' integration tests (#3806)

* test(core): remove update-default-id integration test

This is covered by 'account-update-default-wallet-id' tests in
public-ln-receive bats tests.

* test(core): move wallet-from-non-existent-account test to wallets-repo tests

* chore(core): remove redundant 'addWallet' function

* chore(core): remove redundant 'addWalletIfNonexistent' function

* chore(core): remove create-usd-wallets debug script

core/api/src/app/accounts/index.ts

@@ -2,7 +2,6 @@ import { AccountsRepository, WalletsRepository } from "@/services/mongoose"
 
 export * from "./account-limit"
 export * from "./add-new-contact"
-export * from "./add-wallet"
 export * from "./create-account"
 export * from "./get-account-transactions-for-contact"
 export * from "./get-contact-by-username"

core/api/test/helpers/user.ts

@@ -2,8 +2,7 @@ import { lndOutside1, safePay } from "./lightning"
 
 import { randomPhone, randomUserId } from "."
 
-import { addWallet, createAccountWithPhoneIdentifier } from "@/app/accounts"
-import { addWalletIfNonexistent } from "@/app/accounts/add-wallet"
+import { createAccountWithPhoneIdentifier } from "@/app/accounts"
 import { getAdminAccounts, getDefaultAccountsConfig } from "@/config"
 
 import { CouldNotFindAccountFromKratosIdError, CouldNotFindError } from "@/domain/errors"
@@ -155,12 +154,6 @@ export const createUserAndWalletFromPhone = async (
     const accountIP = await AccountsIpsRepository().update(accountIp)
     if (!(accountIP instanceof CouldNotFindError) && accountIP instanceof Error)
       throw accountIP
-
-    await addWalletIfNonexistent({
-      currency: WalletCurrency.Usd,
-      accountId: account.id,
-      type: WalletType.Checking,
-    })
   }
 
   if (account instanceof Error) throw account
@@ -190,20 +183,14 @@ export const createRandomUserAndWallets = async (): Promise<{
   const phone = randomPhone()
   const btcWalletDescriptor = await createUserAndWallet(phone)
 
-  const usdWallet = await addWalletIfNonexistent({
-    currency: WalletCurrency.Usd,
-    accountId: btcWalletDescriptor.accountId,
-    type: WalletType.Checking,
-  })
-  if (usdWallet instanceof Error) throw usdWallet
+  const accountWallets = await WalletsRepository().findAccountWalletsByAccountId(
+    btcWalletDescriptor.accountId,
+  )
+  if (accountWallets instanceof Error) throw accountWallets
 
   return {
     btcWalletDescriptor,
-    usdWalletDescriptor: {
-      id: usdWallet.id,
-      currency: WalletCurrency.Usd,
-      accountId: usdWallet.accountId,
-    },
+    usdWalletDescriptor: accountWallets.USD,
   }
 }
 
@@ -256,12 +243,6 @@ export const createUserAndWallet = async (
     const accountIP = await AccountsIpsRepository().update(accountIp)
     if (!(accountIP instanceof CouldNotFindError) && accountIP instanceof Error)
       throw accountIP
-
-    await addWalletIfNonexistent({
-      currency: WalletCurrency.Usd,
-      accountId: account.id,
-      type: WalletType.Checking,
-    })
   }
 
   if (account instanceof Error) throw account
@@ -286,11 +267,10 @@ export const addNewWallet = async ({
   accountId: AccountId
   currency: WalletCurrency
 }): Promise<Wallet> => {
-  // Create wallet for account (phone number)
-  const wallet = await addWallet({
-    currency,
+  const wallet = await WalletsRepository().persistNew({
     accountId,
     type: WalletType.Checking,
+    currency,
   })
   if (wallet instanceof Error) throw wallet
 

core/api/test/integration/services/wallets-repository.spec.ts

@@ -1,13 +1,17 @@
 import { randomUUID } from "crypto"
 
+import mongoose from "mongoose"
+
 import {
+  CouldNotFindAccountFromIdError,
   CouldNotFindWalletFromAccountIdAndCurrencyError,
   MultipleWalletsFoundForAccountIdAndCurrency,
   RepositoryError,
 } from "@/domain/errors"
 import { WalletCurrency } from "@/domain/shared"
 import { WalletsRepository } from "@/services/mongoose"
 import { Wallet } from "@/services/mongoose/schema"
+import { WalletType } from "@/domain/wallets"
 
 const wallets = WalletsRepository()
 const accountId = randomUUID() as AccountId
@@ -82,4 +86,17 @@ describe("WalletsRepository", () => {
       expect((accountWallets as RepositoryError).message).toBe(WalletCurrency.Usd)
     })
   })
+
+  describe("persistNew", () => {
+    it("fail to create a wallet with non-existent account", async () => {
+      const id = new mongoose.Types.ObjectId()
+
+      const newWallet = await wallets.persistNew({
+        accountId: id as unknown as AccountId,
+        type: WalletType.Checking,
+        currency: WalletCurrency.Btc,
+      })
+      expect(newWallet).toBeInstanceOf(CouldNotFindAccountFromIdError)
+    })
+  })
 })