perf(core): update mongodb default connection settings (#4646)

* perf(core): update mongodb default connection settings * fix: remove unnecessary read preferences * fix: compressor settings * chore: update default mongodb connection settings * fix: remove read preference from admin legacy ledger
GaloyMoney · Nov 6, 2024 · ccd31cc · ccd31cc
1 parent ef41d9f
commit ccd31cc
Show file tree

Hide file tree

Showing 12 changed files with 296 additions and 241 deletions.
diff --git a/core/api/package.json b/core/api/package.json
@@ -113,6 +113,7 @@
     "prom-client": "^15.1.3",
     "rate-limiter-flexible": "^5.0.1",
     "redlock": "^5.0.0-beta.2",
+    "snappy": "^7.2.2",
     "svix": "1.37.0",
     "tiny-secp256k1": "^2.2.3",
     "twilio": "^5.3.4",

diff --git a/core/api/src/debug/add-payment-request-all-wallet-invoice.ts b/core/api/src/debug/add-payment-request-all-wallet-invoice.ts
@@ -135,7 +135,7 @@ const updateWalletInvoiceWithPaymentRequest = wrapAsyncToRunInSpan({
   },
 })
 
-setupMongoConnection(false)
+setupMongoConnection()
   .then(async (mongoose) => {
     await Promise.all(lndsConnect.map((lndParams) => isUp(lndParams)))
     await main()

diff --git a/core/api/src/debug/clean-pending-payments-for-dead-node.ts b/core/api/src/debug/clean-pending-payments-for-dead-node.ts
@@ -79,7 +79,7 @@ const main = async (): Promise<true | ApplicationError> => {
   return true
 }
 
-setupMongoConnection(false)
+setupMongoConnection()
   .then(async (mongoose) => {
     await Promise.all(lndsConnect.map((lndParams) => isUp(lndParams)))
     await main()

diff --git a/core/api/src/debug/migrate-ln-payments-listpayments.ts b/core/api/src/debug/migrate-ln-payments-listpayments.ts
@@ -259,7 +259,7 @@ const getFirstIndex = async (pubkey: Pubkey): Promise<number | ApplicationError>
     : parseInt(indexMatch) + 1
 }
 
-setupMongoConnection(false)
+setupMongoConnection()
   .then(async (mongoose) => {
     await Promise.all(lndsConnect.map((lndParams) => isUp(lndParams)))
     await main()

diff --git a/core/api/src/debug/migrate-ln-payments-trackpaymentsv2.ts b/core/api/src/debug/migrate-ln-payments-trackpaymentsv2.ts
@@ -137,7 +137,7 @@ const migrateLnPayment = async (
     },
   )
 
-setupMongoConnection(false)
+setupMongoConnection()
   .then(async (mongoose) => {
     await Promise.all(lndsConnect.map((lndParams) => isUp(lndParams)))
     await main()

diff --git a/core/api/src/servers/exporter.ts b/core/api/src/servers/exporter.ts
@@ -211,7 +211,10 @@ const main = async () => {
   activateLndHealthCheck()
 }
 
-setupMongoConnection()
+setupMongoConnection({
+  syncIndexes: false,
+  options: { readPreference: "secondaryPreferred", socketTimeoutMS: 120000 },
+})
   .then(() => main())
   .catch((err) => logger.error(err))
 

diff --git a/core/api/src/servers/graphql-main-server.ts b/core/api/src/servers/graphql-main-server.ts
@@ -7,7 +7,7 @@ import { activateLndHealthCheck } from "@/services/lnd/health"
 import { baseLogger } from "@/services/logger"
 import { setupMongoConnection } from "@/services/mongodb"
 
-setupMongoConnection(true)
+setupMongoConnection({ syncIndexes: true })
   .then(async () => {
     activateLndHealthCheck()
 

diff --git a/core/api/src/services/ledger/admin-legacy.ts b/core/api/src/services/ledger/admin-legacy.ts
@@ -29,9 +29,7 @@ const getWalletBalance = async (account: string, query = {}) => {
 
   const balancePromise = (async () => {
     try {
-      const { balance } = await MainBookAdmin.balance(params, {
-        readPreference: "secondaryPreferred",
-      })
+      const { balance } = await MainBookAdmin.balance(params)
       return balance
     } finally {
       inProgressQueries.delete(inProgressKey)

diff --git a/core/api/src/services/ledger/index.ts b/core/api/src/services/ledger/index.ts
@@ -312,12 +312,9 @@ export const LedgerService = (): ILedgerService => {
   ): Promise<Satoshis | LedgerError> => {
     const liabilitiesWalletId = toLiabilitiesWalletId(walletId)
     try {
-      const { balance } = await MainBook.balance(
-        {
-          account: liabilitiesWalletId,
-        },
-        { readPreference: "primaryPreferred" },
-      )
+      const { balance } = await MainBook.balance({
+        account: liabilitiesWalletId,
+      })
       if (balance < 0) {
         const dealerUsdWalletId = await caching.getDealerUsdWalletId()
         const dealerBtcWalletId = await caching.getDealerBtcWalletId()
@@ -343,12 +340,9 @@ export const LedgerService = (): ILedgerService => {
   ): Promise<BalanceAmount<S> | LedgerError> => {
     const liabilitiesWalletId = toLiabilitiesWalletId(walletDescriptor.id)
     try {
-      const { balance } = await MainBook.balance(
-        {
-          account: liabilitiesWalletId,
-        },
-        { readPreference: "primaryPreferred" },
-      )
+      const { balance } = await MainBook.balance({
+        account: liabilitiesWalletId,
+      })
       if (balance < 0) {
         const dealerWalletIds = Object.values(await caching.getDealerWalletIds())
 

diff --git a/core/api/src/services/mongodb/index.ts b/core/api/src/services/mongodb/index.ts
@@ -17,6 +17,36 @@ import { WalletCurrency } from "@/domain/shared"
 import { lazyLoadLedgerAdmin } from "@/services/ledger"
 import { WalletsRepository } from "@/services/mongoose"
 
+type SetupMongoConnectionArgs = {
+  syncIndexes: boolean
+  options?: mongoose.ConnectOptions
+}
+
+const DEFAULT_MONGODB_OPTIONS: mongoose.ConnectOptions = {
+  autoIndex: false,
+  compressors: ["snappy", "zlib"],
+
+  maxPoolSize: 100,
+  minPoolSize: 15,
+  maxConnecting: 5, // Maximum number of concurrent connection attempts
+
+  socketTimeoutMS: 60000, // Close sockets after 60 seconds of inactivity
+  connectTimeoutMS: 15000, // Give up initial connection after 15 seconds
+  serverSelectionTimeoutMS: 15000, // Keep trying to send operations for 15 seconds
+
+  retryWrites: true,
+  writeConcern: {
+    w: "majority", // Wait for majority acknowledgment
+    j: true, // Wait for journal commit
+    wtimeout: 10000, // Write timeout
+  },
+
+  retryReads: true,
+  maxStalenessSeconds: 90,
+  readPreference: "primaryPreferred", // Prefer primary but allow secondary reads
+  readConcern: { level: "majority" }, // Read from majority-committed data
+} as const
+
 export const ledgerAdmin = lazyLoadLedgerAdmin({
   bankOwnerWalletResolver: async () => {
     const result = await Account.findOne({ role: "bankowner" }, { defaultWalletId: 1 })
@@ -63,9 +93,11 @@ export const ledgerAdmin = lazyLoadLedgerAdmin({
 // TODO add an event listenever if we got disconnecter from MongoDb
 // after a first successful connection
 
-export const setupMongoConnection = async (syncIndexes = false) => {
+export const setupMongoConnection = async (
+  { syncIndexes, options }: SetupMongoConnectionArgs = { syncIndexes: false },
+) => {
   try {
-    await mongoose.connect(MONGODB_CON, { autoIndex: false })
+    await mongoose.connect(MONGODB_CON, { ...DEFAULT_MONGODB_OPTIONS, ...options })
   } catch (err) {
     baseLogger.fatal(`error connecting to mongodb`)
     throw err

diff --git a/core/api/test/integration/jest.setup.js b/core/api/test/integration/jest.setup.js
@@ -13,7 +13,7 @@ jest.mock("@/services/lnd/auth", () => {
 jest.mock("@/app/prices/get-current-price", () => require("test/mocks/get-current-price"))
 
 beforeAll(async () => {
-  mongoose = await setupMongoConnection(true)
+  mongoose = await setupMongoConnection({ syncIndexes: true })
 })
 
 afterAll(async () => {