ci: handle empty relevant commits array (#3770)

GaloyMoney · Jan 2, 2024 · bd2aa4e · bd2aa4e
1 parent df6c9e9
commit bd2aa4e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/ci/apps/tasks/open-charts-pr.sh b/ci/apps/tasks/open-charts-pr.sh
@@ -81,11 +81,15 @@ ${github_url}/compare/${APP}-${old_ref}...${APP}-${ref}
 Relevant commits:
 EOF
 
-for commit in "${relevant_commits[@]}"; do
-  cat <<EOF >> ../body.md
-- ${github_url}/commit/${commit}
-EOF
-done
+if [[ "${#relevant_commits[@]}" -eq 0 ]]; then
+  echo "- No relevant commits found" >> ../body.md
+else
+  for commit in "${relevant_commits[@]}"; do
+    cat <<-EOF >> ../body.md
+		- ${github_url}/commit/${commit}
+		EOF
+  done
+fi
 
 cat <<EOF >> ../body.md
 

diff --git a/ci/tasks/open-charts-pr.sh b/ci/tasks/open-charts-pr.sh
@@ -82,11 +82,15 @@ ${github_url}/compare/core-${old_ref}...core-${ref}
 Relevant commits:
 EOF
 
-for commit in "${relevant_commits[@]}"; do
-  cat <<EOF >> ../body.md
-- ${github_url}/commit/${commit}
-EOF
-done
+if [[ "${#relevant_commits[@]}" -eq 0 ]]; then
+  echo "- No relevant commits found" >> ../body.md
+else
+  for commit in "${relevant_commits[@]}"; do
+    cat <<-EOF >> ../body.md
+		- ${github_url}/commit/${commit}
+		EOF
+  done
+fi
 
 cat <<EOF >> ../body.md