chore(core): add disposable phone validation (#3598)

core/api/package.json

@@ -36,6 +36,7 @@
     "@google-cloud/storage": "^7.6.0",
     "@grpc/grpc-js": "^1.9.10",
     "@grpc/proto-loader": "^0.7.10",
+    "@ip1sms/disposable-phone-numbers": "^2.1.600",
     "@opentelemetry/api": "^1.7.0",
     "@opentelemetry/core": "^1.18.1",
     "@opentelemetry/exporter-trace-otlp-http": "^0.45.1",

core/api/src/services/twilio-service.ts

@@ -1,6 +1,6 @@
 import twilio from "twilio"
-
 import { isAxiosError } from "axios"
+import disposablePhoneList from "@ip1sms/disposable-phone-numbers"
 
 import { wrapAsyncFunctionsToRunInSpan } from "./tracing"
 
@@ -49,13 +49,18 @@ export const TwilioClient = (): IPhoneProviderService => {
     channel: ChannelType
   }): Promise<true | PhoneProviderServiceError> => {
     try {
+      if (isDisposablePhoneNumber(to)) {
+        return new InvalidTypePhoneProviderError()
+      }
+
       const lookup = await client.lookups.v2.phoneNumbers(to).fetch({
         fields: "line_type_intelligence",
       })
       // https://www.twilio.com/docs/lookup/v2-api/line-type-intelligence#type-property-values
       if (lookup.lineTypeIntelligence.type === "nonFixedVoip") {
         return new InvalidTypePhoneProviderError()
       }
+
       await verify.verifications.create({ to, channel })
     } catch (err) {
       baseLogger.error({ err }, "impossible to send text")
@@ -226,3 +231,8 @@ export const isPhoneCodeValid = async ({
 
   return TwilioClient().validateVerify({ to: phone, code })
 }
+
+export const isDisposablePhoneNumber = (phone: PhoneNumber) => {
+  const phoneNumber = phone.replace(/[^0-9]/, "")
+  return phoneNumber in disposablePhoneList
+}

core/api/test/unit/services/twilio/is-disposable-phone-number.spec.ts

@@ -0,0 +1,16 @@
+import { isDisposablePhoneNumber } from "@/services/twilio-service"
+
+describe("Twilio Service", () => {
+  describe("isDisposablePhoneNumber", () => {
+    const amounts = [
+      { phone: "+34689682259", expected: true },
+      { phone: "34689682259", expected: true },
+      { phone: "+34699682259", expected: false },
+      { phone: "34699682259", expected: false },
+    ]
+    test.each(amounts)("phone $phone is disposable: $expected", ({ phone, expected }) => {
+      const result = isDisposablePhoneNumber(phone as PhoneNumber)
+      expect(result).toEqual(expected)
+    })
+  })
+})