chore(core): address pr feedback

- correct error names
- use tracing in lnurl-pay service

core/api/src/app/errors.ts

@@ -6,7 +6,7 @@ import * as CallbackErrors from "@/domain/callback/errors"
 import * as CommErrors from "@/domain/comm/errors"
 import * as OnChainErrors from "@/domain/bitcoin/onchain/errors"
 import * as LightningErrors from "@/domain/bitcoin/lightning/errors"
-import * as LnurlErrors from "@/domain/bitcoin/lnurl/errors"
+import * as LnurlServiceErrors from "@/domain/bitcoin/lnurl/errors"
 import * as PriceServiceErrors from "@/domain/price/errors"
 import * as LockServiceErrors from "@/domain/lock/errors"
 import * as RateLimitServiceErrors from "@/domain/rate-limit/errors"
@@ -36,7 +36,7 @@ export const ApplicationErrors = {
   ...CommErrors,
   ...OnChainErrors,
   ...LightningErrors,
-  ...LnurlErrors,
+  ...LnurlServiceErrors,
   ...PriceServiceErrors,
   ...LockServiceErrors,
   ...RateLimitServiceErrors,

core/api/src/domain/bitcoin/lnurl/errors.ts

@@ -1,7 +1,7 @@
 import { DomainError, ErrorLevel } from "@/domain/shared"
 
-export class LnurlError extends DomainError {}
-export class ErrorFetchingLnurlInvoice extends LnurlError {}
-export class UnknownLnurlError extends LnurlError {
+export class LnurlServiceError extends DomainError {}
+export class ErrorFetchingLnurlInvoice extends LnurlServiceError {}
+export class UnknownLnurlServiceError extends LnurlServiceError {
   level = ErrorLevel.Critical
 }

core/api/src/domain/bitcoin/lnurl/index.types.d.ts

@@ -1,7 +1,7 @@
-type LnurlError = import("@/domain/bitcoin/lnurl/errors").LnurlError
+type LnurlServiceError = import("@/domain/bitcoin/lnurl/errors").LnurlServiceError
 interface ILnurlPayService {
   fetchInvoiceFromLnAddressOrLnurl(args: {
     amount: BtcPaymentAmount
     lnAddressOrLnurl: string
-  }): Promise<string | LnurlError>
+  }): Promise<string | LnurlServiceError>
 }

core/api/src/graphql/error-map.ts

@@ -660,7 +660,7 @@ export const mapError = (error: ApplicationError): CustomGraphQLError => {
     case "ExpectedAddressInfoMissingInEventError":
     case "MissingCreatedAtKratosError":
     case "MissingExpiredAtKratosError":
-    case "LnurlError":
+    case "LnurlServiceError":
     case "InvalidIdentitySessionKratosError":
     case "MissingTotpKratosError":
     case "IncompatibleSchemaUpgradeError":
@@ -730,7 +730,7 @@ export const mapError = (error: ApplicationError): CustomGraphQLError => {
     case "UnknownOnChainServiceError":
     case "UnknownNotificationsServiceError":
     case "UnknownIpFetcherServiceError":
-    case "UnknownLnurlError":
+    case "UnknownLnurlServiceError":
     case "UnknownCacheServiceError":
     case "UnknownPhoneProviderServiceError":
     case "UnknownDealerPriceServiceError":

core/api/src/services/lnurl-pay/index.ts

@@ -3,9 +3,10 @@ import { utils, requestInvoice } from "lnurl-pay"
 import { toSats } from "@/domain/bitcoin"
 import {
   ErrorFetchingLnurlInvoice,
-  LnurlError,
-  UnknownLnurlError,
+  LnurlServiceError,
+  UnknownLnurlServiceError,
 } from "@/domain/bitcoin/lnurl/errors"
+import { wrapAsyncFunctionsToRunInSpan } from "../tracing"
 
 export const LnurlPayService = (): ILnurlPayService => {
   const fetchInvoiceFromLnAddressOrLnurl = async ({
@@ -14,7 +15,7 @@ export const LnurlPayService = (): ILnurlPayService => {
   }: {
     amount: BtcPaymentAmount
     lnAddressOrLnurl: string
-  }): Promise<string | LnurlError> => {
+  }): Promise<string | LnurlServiceError> => {
     try {
       const invoice = await requestInvoice({
         lnUrlOrAddress: lnAddressOrLnurl,
@@ -32,11 +33,14 @@ export const LnurlPayService = (): ILnurlPayService => {
       if (err instanceof Error) {
         return new ErrorFetchingLnurlInvoice(err.message)
       }
-      return new UnknownLnurlError(err)
+      return new UnknownLnurlServiceError(err)
     }
   }
 
-  return {
-    fetchInvoiceFromLnAddressOrLnurl,
-  }
+  return wrapAsyncFunctionsToRunInSpan({
+    namespace: "services.lnurl-pay",
+    fns: {
+      fetchInvoiceFromLnAddressOrLnurl,
+    },
+  })
 }