refactor: remove optional types from ILedgerTransaction

GaloyMoney · Nov 10, 2023 · 18d764e · 18d764e
1 parent c7bbeea
commit 18d764e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/api/src/services/ledger/schema.types.d.ts b/core/api/src/services/ledger/schema.types.d.ts
@@ -1,5 +1,5 @@
 interface ILedgerTransaction {
-  _id?: ObjectId
+  _id: ObjectId
   credit: number
   debit: number
   meta?: { [k: string]: unknown }
@@ -10,8 +10,8 @@ interface ILedgerTransaction {
   memo: string
   _journal: ObjectId
   timestamp: Date
-  voided?: boolean
-  void_reason?: string
+  voided: boolean
+  void_reason: string
   _original_journal?: ObjectId
 
   hash?: string

diff --git a/core/api/test/unit/domain/ledger/index.spec.ts b/core/api/test/unit/domain/ledger/index.spec.ts
@@ -20,6 +20,7 @@ describe("LedgerService", () => {
       _journal: toObjectId(sampleJournalId),
       timestamp,
       voided: false,
+      void_reason: "",
 
       hash: "hash",
       txid: "txid",