Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reactive price screen #3271

Merged
merged 1 commit into from
May 16, 2024
Merged

feat: reactive price screen #3271

merged 1 commit into from
May 16, 2024

Conversation

UncleSamtoshi
Copy link
Contributor

  • allow hovering over prices
  • use price of 1 btc

@UncleSamtoshi UncleSamtoshi force-pushed the update-price-page branch 2 times, most recently from 1fb3975 to 5b31042 Compare May 16, 2024 21:10
@UncleSamtoshi
Copy link
Contributor Author

image

@nicolasburtey
Copy link
Member

We should probably stack button for timeframe at the bottom of the screen

Would be good to have maybe the vertical axis back

@UncleSamtoshi
Copy link
Contributor Author

I think now that you can hover over prices the vertical axis may not be neccessary. It also keeps the chart symmetrical by not having them. As for the buttons we could move them down, but the but the buy bitcoin button will be below it for some users and personally think its looks better with them right next to the chart. Willing to change it if you feel strongly though!

@UncleSamtoshi UncleSamtoshi merged commit 4021d45 into main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasburtey nicolasburtey nicolasburtey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UncleSamtoshi @nicolasburtey