feat: improve deep linking #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
UncleSamtoshi
commented
Apr 18, 2024
•
UncleSamtoshi
commented
- fix linking logic
- add more deeplinks
- enable deeplinks to open "set account", "set ln address", and "upgrade account" modals.
|
|
||
| const { data } = useSetDefaultAccountModalQuery({ | ||
| fetchPolicy: "cache-only", | ||
| fetchPolicy: "cache-first", |
There was a problem hiding this comment.
skimming though the code, I think this is adding a network request for every time the app launches. not ideal
There was a problem hiding this comment.
Yeah i thought there might be a chance that it doesn't exist in the cache, but I actually think that wont happen or will at least be rare. I will switch it back.
UncleSamtoshi
force-pushed
the
improve-deep-linking
branch
from
150a749
to
7707e59
Compare
nicolasburtey
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.