Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plist localizations #3041

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaxwellDG
Copy link
Contributor

@MaxwellDG MaxwellDG commented Feb 1, 2024

Addresses #611

This is a draft, but if its approved that we want to do this, Ill write a script to make the addition of new languages automated. At the moment I've only written 1 line in the il8n README, but Ill expand that to include the aforementioned script.

Also take note that I made 2 small changes to info.plist. We had a duplicate in there, and I removed a variable. Doesn't look like xCode localization .string files permit system variables like that.

@nicolasburtey
Copy link
Member

I think this PR is great and very well needed

ideally we would want to add those files somehow into transifex which is where people who are helping doing translation are going, and having everything centralized to transifex makes it much easier.

https://app.transifex.com/galoy/bitcoin-beach-wallet/

but now the challenge for integrating transifex is the upload/download from transifix and format management. I'm not sure if transifex would be working well with the InfoPlist.strings format. maybe worth researching.

I could see how this could be done manually because it's only a few strings, but if we add a string into this list, or add a new language, then it become a higher burden to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants