chore: only ask for rate us on successful payment #2942
Conversation
| useEffect(() => { | ||
| if (!feedbackModalShown) { | ||
| if (!showSuggestionModal) { |
There was a problem hiding this comment.
I think this may be a bug. showSuggestionModal always starts as false until feedback is given. As it is written, the screen will navigate to home at the same time that feedback is requested.
There was a problem hiding this comment.
this is indeed what it is doing: going to the home screen and asking for a feedback at the same time.
and this was also what was done before, so this PR doesn't change anything for this.
what behavior would you suggest? first ask for feedback and delay the return to home? or the opposite?
There was a problem hiding this comment.
I think before it was requesting feedback and after that happened it would go to the home screen. Previously, line 100 would be an early return if feedbackModalShown was false and so it wouldn't call the setTimeout to navigate to the home screen in line 105. I think now this screen will be unmounted by the time a suggestion modal would be popped up.
No description provided.