Merge pull request #549 from Galooshi/omitted-array-destructure

Handle omitted array destructure
Galooshi · Dec 10, 2019 · 2a9c1a9 · 2a9c1a9
2 parents 84e72bb + 29e1b88
commit 2a9c1a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/__tests__/findUndefinedIdentifiers-test.js b/lib/__tests__/findUndefinedIdentifiers-test.js
@@ -214,3 +214,9 @@ it('knows about object rest', () => {
     const { a, ...theRest } = someObject;
   `))).toEqual(new Set([]));
 });
+
+it('can handle omitted array destructure', () => {
+  expect(findUndefinedIdentifiers(parse(`
+  const [,bar] = foo();
+  `))).toEqual(new Set(['foo']));
+});
diff --git a/lib/visitIdentifierNodes.js b/lib/visitIdentifierNodes.js
@@ -85,6 +85,9 @@ export default function visitIdentifierNodes(
 
   while (queue.length) {
     current = queue.shift();
+    if (!current.node) {
+      continue; // eslint-disable-line
+    }
     if (Array.isArray(current.node)) {
       if (current.context.key === 'body') {
         // A new scope has started. Copy whatever we have from the parent scope