On OSX, '-mmacosx-version-min=XXX' compile and link options management #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asked by MACOSX_DEPLOYMENT_TARGET environment variable
mglisse
approved these changes
Sep 8, 2023
src/python/CMakeLists.txt
Outdated
| @@ -255,8 +255,11 @@ if(PYTHONINTERP_FOUND) | |||
|
|
|||
| # Specific for Mac | |||
| if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin") | |||
| set(GUDHI_PYTHON_EXTRA_COMPILE_ARGS "${GUDHI_PYTHON_EXTRA_COMPILE_ARGS}'-mmacosx-version-min=10.14', ") | |||
| set(GUDHI_PYTHON_EXTRA_LINK_ARGS "${GUDHI_PYTHON_EXTRA_LINK_ARGS}'-mmacosx-version-min=10.14', ") | |||
| # if MACOSX_DEPLOYMENT_TARGET environment variable is set | |||
There was a problem hiding this comment.
Isn't CMAKE_OSX_DEPLOYMENT_TARGET always defined? (not an issue, just surprised by the comment)
There was a problem hiding this comment.
I was not aware of this behavior, but yes you are right, it seems CMAKE_OSX_DEPLOYMENT_TARGET is always set on OSx. I reworked the comment on ee221bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when asked by MACOSX_DEPLOYMENT_TARGET environment variable.
Fix #899