Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Numeric widget and localized number formatting. #272

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

AbdielKavash
Copy link
Member

 

Notes:

  • I have not touched Parametrizer Hatches, they are deprecated and uncraftable, even though they contain some code that should have been changed if they were still intended to be used. This will not break any setups that still use them; although their UI will not have the new features.
  • Some labels currently display as gray, when they are intended to be a different color. This is already fixed in Dynamic text color fix. ModularUI#70, and will be automatically corrected once new releases of MUI and GT5 are published.
  • Tracking down every single instance where a mod writes a number is nearly impossible. I use a few heuristics and code searches, but it is very likely that I miss some places. If an UI displays an unformatted or wrongly formatted number somewhere, please report it to be fixed.

Preview:

This is the first real field implementation of the localization and UI changes I've been working on for a while. I chose to start with TT simply because it has fewest places where the changes are applicable. I will continue working through all other mods that use ModularUI.

@AbdielKavash AbdielKavash requested review from miozune and a team March 7, 2024 08:57
@AbdielKavash AbdielKavash marked this pull request as draft March 9, 2024 05:33
@AbdielKavash AbdielKavash marked this pull request as ready for review March 9, 2024 06:09
@AbdielKavash AbdielKavash merged commit 6206495 into GTNewHorizons:master Mar 9, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants