This repository has been archived by the owner on May 24, 2024. It is now read-only.
Forge of the Gods #225
Merged
Forge of the Gods #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dependencies.gradle
…ternal fuel battery
BlueWeabo
reviewed
Mar 11, 2024
src/main/java/com/github/technus/tectech/util/GodforgeMath.java
Outdated
Show resolved
Hide resolved
...s/tectech/thing/metaTileEntity/multi/godforge_modules/GT_MetaTileEntity_EM_PlasmaModule.java
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
+45
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(0.0F, -1.0F, 0.0F); | ||
| renderer.renderFaceYNeg(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); | ||
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(0.0F, 0.0F, -1.0F); | ||
| renderer.renderFaceZNeg(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); | ||
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(0.0F, 0.0F, 1.0F); | ||
| renderer.renderFaceZPos(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); | ||
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(-1.0F, 0.0F, 0.0F); | ||
| renderer.renderFaceXNeg(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); | ||
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(1.0F, 0.0F, 0.0F); | ||
| renderer.renderFaceXPos(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); | ||
| tessellator.startDrawingQuads(); | ||
| tessellator.setNormal(0.0F, 1.0F, 0.0F); | ||
| renderer.renderFaceYPos(block, 0.0D, 0.0D, 0.0D, side); | ||
| tessellator.draw(); |
There was a problem hiding this comment.
I think it would be better to draw once instead of multiple times here.. You can get the uvMin/Max from the icon texture.
There was a problem hiding this comment.
Will deal with this later
src/main/java/com/github/technus/tectech/thing/block/GodforgeGlassRender.java
Show resolved
Hide resolved
...com/github/technus/tectech/thing/metaTileEntity/multi/GT_MetaTileEntity_EM_EyeOfHarmony.java
Outdated
Show resolved
Hide resolved
mitchej123
reviewed
Mar 11, 2024
src/main/java/com/github/technus/tectech/thing/block/GodforgeGlassRender.java
Outdated
Show resolved
Hide resolved
BlueWeabo
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: boubou told me to get this merged, which is why I have undrafted this now. There is still work to be done, that will happen in a new PR if this gets merged.
Doc: https://docs.google.com/document/d/1Lpt73uBFvdEvF_Wx0dfHodfxW4zCSyxlcRwd9XUhH-A/edit?usp=sharing
Disclaimer: heavily WIP, any opinions on this would be much appreciated
This PR adds the forge of gods, a new multiblock akin to the starforge Nidavellir seen in the marvel universe, using a neutron star as a heat source to smelt metals at astonishing rates.
The primary purposes of this multiblock are solving the blast furnace spam at late-endgame and adding a base for the next circuit line featuring exotic forms of matter. This multi will be tiered at UIV tier to add more content to said tier and because it makes sense thematically.
Featuring multiple space elevator-esque modules that can do regular mass smelting, smelting into fluids, creating plasmas directly from materials and superheating and oblitterating matter into its most basic building blocks using wireless energy directly.
Furthermore this multi is planned to feature unique mechanics regarding heat bonuses, overclocks (?) and general upgrades to the multi (interactive upgrade tree).
The multi will also feature a custom renderer for the neutron star in the middle of the structure and rotating rings (if possible).
The currently available and fully functional modules of the multiblock are (names are preliminary):
Image of the current structure
Non-exhaustive list of what still needs doing: