Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables weather completely on The Last Millenium #418

Merged

Conversation

Kogepan229
Copy link
Contributor

If it's raining in the Overworld and you enter The Last Millenium, it will still be raining, so fixes this.

The code is copied from Personal Space.
https://github.com/GTNewHorizons/PersonalSpace/blob/d26f154f327bac6ac55f8e08214363cf39d9ce0f/src/main/java/me/eigenraven/personalspace/world/PersonalWorldProvider.java#L197

@Dream-Master Dream-Master requested a review from a team September 6, 2024 11:44
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can be merged if tested.

@Kogepan229
Copy link
Contributor Author

I've been using this as its own mod with GTNH2.6.1 for a while now and it works fine.
2024-09-06_21 42 13

@glowredman glowredman merged commit e4bf115 into GTNewHorizons:master Sep 6, 2024
1 check passed
@Kogepan229 Kogepan229 deleted the fix-disable-lastmillenium-rain branch September 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants