Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for fixNetHandlerLoginServerOfflineMode #258

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/mitchej123/hodgepodge/LoadingConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public class LoadingConfig {
public boolean fixJourneymapKeybinds;
public boolean fixJourneymapJumpyScrolling;
public boolean fixJourneymapFilePath;
public boolean fixNetHandlerLoginServerOfflineMode;
public boolean fixNetHandlerPlayClientHandleSetSlot;
public boolean fixNetherLeavesFaceRendering;
public boolean fixNorthWestBias;
Expand Down Expand Up @@ -254,6 +255,7 @@ public LoadingConfig(File file) {
fixJourneymapKeybinds = config.get(Category.FIXES.toString(), "fixJourneymapKeybinds", true, "Prevent unbinded keybinds from triggering when pressing certain keys").getBoolean();
fixJourneymapJumpyScrolling = config.get(Category.FIXES.toString(), "fixJourneymapJumpyScrolling", true, "Fix jumpy scrolling in the waypoint manager screen").getBoolean();
fixJourneymapFilePath = config.get(Category.FIXES.toString(), "fixJourneymapFilePath", true, "Prevents journeymap from using illegal character in file paths").getBoolean();
fixNetHandlerLoginServerOfflineMode = config.get(Category.FIXES.toString(), "fixNetHandlerLoginServerOfflineMode", true, "Allows the server to assign the logged in UUID to the same username when online_mode is false").getBoolean();
fixNetHandlerPlayClientHandleSetSlot = config.get(Category.FIXES.toString(), "fixNetHandlerPlayClientHandleSetSlot", true, "Prevents crash if server sends itemStack with index larger than client's container").getBoolean();
fixNetherLeavesFaceRendering = config.get(Category.FIXES.toString(), "fixNetherLeavesFaceRendering", true, "If fancy graphics are enabled, Nether Leaves render sides with other Nether Leaves adjacent too").getBoolean();
fixNorthWestBias = config.get(Category.FIXES.toString(), "fixNorthWestBias", true, "Fix northwest bias on RandomPositionGenerator").getBoolean();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/mitchej123/hodgepodge/mixins/Mixins.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public enum Mixins {
FIX_NETHANDLERLOGINSERVER_OFFLINEMODE(
new Builder("Allows the server to assign the logged in UUID to the same username when online_mode is false")
.setPhase(Phase.EARLY).addMixinClasses("minecraft.MixinNetHandlerLoginServer_OfflineMode")
.setSide(Side.SERVER).setApplyIf(() -> true) /* no config option for this */
.setSide(Side.SERVER).setApplyIf(() -> Common.config.fixNetHandlerLoginServerOfflineMode)
.addTargetedMod(TargetedMod.VANILLA)),
FIX_INVENTORY_POTION_EFFECT_NUMERALS(
new Builder("Fix potion effects level not displaying properly above a certain value").setPhase(Phase.EARLY)
Expand Down