-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixin package refactor #247
Conversation
Warning: 2 uncommitted changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I don't see the point. Just changing the common
package to a different name should suffice, if at all. Thoughts, @mitchej123?
when you make mixins you sometime needs external interfaces to call methods or you create class hooks and it makes sense to put them under a mixin package that's all |
I completely understand what you mean, I just don't agree. When I see a package called "mixin(s)" I expect everything inside to be directly responsible for bytecode manipulation via the Mixins framework and nothing else. |
I am not a machine, I can work things out when they don't meet my expectations.
Yes because one of these doesn't actually contain mixins, the classes are just somewhat related. ItemBlocks don't belong in an item(s) package either. They are related to blocks but aren't actually blocks. |
I guess we disagreee, @mitchej123 what do you think ? |
I'm not a fan the mixins being nested, so I'm with glowredman on this one |
Moved all mixins from
mixins
package tomixin/mixins
package so we can put the mixins related hooks and other classes in themixin
package and not have them sit in acommon package