Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dark Steel Anvils in WAILA #152

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

connor135246
Copy link

The WAILA integration for the Dark Steel Anvil didn't work if the "Sneaky Facades" option was on (which it is by default). The integration fixes the metadata used to display the block. With "Sneaky Facades" on, if you were looking at undamaged Dark Steel Anvils facing certain directions, they would display as Slightly Damaged or Very Damaged. Slightly Damaged and Very Damaged would always display as undamaged.

It was like this:

if (config("Sneaky Facades"))
{
  if (block instanceof Facade)
  {
    ...
  }
}
else if (block instanceof Dark Steel Anvil)
{
  ...
}

When it should be like this:

if (config("Sneaky Facades") && block instanceof Facade)
{
  ...
}
else if (block instanceof Dark Steel Anvil)
{
  ...
}

Dark Steel Anvils wouldn't show the correct block in WAILA if the "Sneaky Facades" option was on.
@Dream-Master Dream-Master requested a review from a team February 21, 2024 23:21
@Dream-Master Dream-Master merged commit fc5cba3 into GTNewHorizons:master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants