Revert "Staff Of Traveling Keybind Feature (#144)" #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3639ade.
|
Fixed in this commit on my fork, should wait till this reversion goes through before making a PR so everything get's re-pushed in the new PR or? |
|
Nah, you can make make a new PR against master |
|
Or I can make it and cherry pick that commit if you prefer |
|
I think I figured it out, #148 created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3639ade.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#15406
Until a better implementation is created, lets go ahead and revert this feature.
Plus scanning your inventory/baubles every tick is not the best way to handle it.