Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mibi/surface closest parameter #237

Merged
merged 6 commits into from
Aug 8, 2021

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR introduces the closest parameters, used to define the closest point.
To find the starting value uses split surface instead of the tessellation.

Related Tickets & Documents

This PR closes #120 #121

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. label Aug 7, 2021
@sonomirco sonomirco self-assigned this Aug 7, 2021
@@ -365,5 +365,95 @@ public void CurveKnotRefine2()

_testOutput.WriteLine($"{after.controlPoints}");
}

[Fact]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore this file, I used to check that everything was working.

Copy link
Collaborator

@cesarecaoduro cesarecaoduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@cesarecaoduro cesarecaoduro merged commit 84a5fb2 into develop Aug 8, 2021
@sonomirco sonomirco deleted the dev/mibi/surface-closest-parameter branch August 9, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface closest parameter
2 participants