Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show required fields label only if form includes required fields #1270

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Oct 19, 2023

We have a simple Yes/No optional questionnaire on our website (example), and I noticed recently the addition of a "required field" label since #1231. The label feels rather out of place for our simple form, which doesn't include any required fields.

The changes proposed here would only display this label on a form which includes required fields.

@ryanwoldatwork
Copy link
Contributor

awesome. thanks @aduth!

@ryanwoldatwork ryanwoldatwork merged commit 718cca7 into GSA:develop Oct 20, 2023
@aduth aduth deleted the aduth-required-fields-label branch October 20, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants