Resolves #1570 Formly button type demo added #1578
Conversation
yerramshilpa
requested review from
carlosvalle,
davereed,
christyhermansen,
shayan-roshan and
cwolf10
as code owners
|
| type: 'button', | ||
| props: { | ||
| enableInput: true, | ||
| // btnIcon: 'plus-circle', |
There was a problem hiding this comment.
Is there a reason to keep these comments in the demo code?
There was a problem hiding this comment.
Removed unused code
| import { FormlyButtonOptionsModule } from './formly-button-options/formly-button-options.module'; | ||
| import { importProvidersFrom } from '@angular/core'; | ||
| import { FormlyButtonConfigurableModule } from './formly-button-configurable/formly-button-configurable.module'; | ||
| const disable = { |
There was a problem hiding this comment.
I'm pretty sure this var isn't being used, if so it can be deleted.
There was a problem hiding this comment.
Removed unused code
| @@ -0,0 +1,31 @@ | |||
| import { Component } from '@angular/core'; | |||
| import { FormGroup } from '@angular/forms'; | |||
| import { SelectionMode } from '@gsa-sam/components'; | |||
There was a problem hiding this comment.
SelectionMode & SdsFormlyTypes are not used, these imports can be removed.
| } | ||
| this.fields = [temp]; | ||
| } | ||
| inpuField = { |
| @@ -0,0 +1,47 @@ | |||
| import { AfterViewInit, Component, Input } from '@angular/core'; | |||
| @@ -0,0 +1,39 @@ | |||
| import { Component } from '@angular/core'; | |||
| import { FormGroup } from '@angular/forms'; | |||
| import { SelectionMode, TabPanelComponent } from '@gsa-sam/components'; | |||
There was a problem hiding this comment.
SelectionMode, TabPanelComponent, SdsFormlyTypes not used
| providers: [provideAnimations(), importProvidersFrom(FormlyModule.forRoot())], | ||
| }), | ||
| ], | ||
| argTypes: {}, |
There was a problem hiding this comment.
I think it'd be good to seperate out enableInput & hasModel from the other two inputs to make clear that they are just inputs to control this particular demo and are not used with the formly type. You could seperate them out by adding to argTypes like how id is seperated out in the pagination configurable demo. Here's a link to that config:
Description
This PR is for adding formly button type demos
#1570
Motivation and Context
Type of Change (Select One and Apply Github Label)
Screenshots
Which browsers have you tested?
Checklist: