1276: Update sdsTableRowNavigation directive #1278
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Adding breaking-change label for visibility. This PR does not contain any breaking changes, but does lay the groundwork for breaking changes in the future. All changes in the PR are just to the internal workings of table-row
This PR lays the groundwork to require highlighting when rowClick event is enabled. The purpose of doing this is to align with Angular Material in how they handle this exact scenario. Currently highlighting is an optional directive and rowClick is always emitting. However, aligning with Material, rows should be highlighted if they are going to emit an event.
In this PR I:
emitOnRowClick
input to ensure event continues emitting in the future.highlightOnHover
input is used. This input will be going away andemitOnRowClick
should be used in it's place.Motivation and Context
#1276. See above for rationale for this change.
Type of Change (Select One and Apply Github Label)
Screenshots (if appropriate):
Which browsers have you tested?
Checklist: