Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hotfix #995

Closed

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Dec 13, 2024

Committer Notes

hotfix constraints and add sample content for better coverage on using resolved profiles and multiple data-flow diagrams

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner December 13, 2024 13:24
Copy link

@DimitriZhurkin DimitriZhurkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@Gabeblis
Copy link
Contributor

What issue is this part of? Is this related to the work done in #991?

@wandmagic
Copy link
Collaborator Author

What issue is this part of? Is this related to the work done in #991?

I noticed this issue when validating the telos SSP, so i thought it would be good to fix it

@wandmagic
Copy link
Collaborator Author

these constraints crash when there are multiple links for these items

@wandmagic
Copy link
Collaborator Author

I have added some extra sample content to help us cover this use case
#993

I wasn't able to reproduce the error, but content pointing to this profile is now included in the test suite

@Gabeblis
Copy link
Contributor

This was handled in PR #991 as part of issue #940

@wandmagic
Copy link
Collaborator Author

This was handled in PR #991 as part of issue #940

ok right on

@wandmagic wandmagic closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants