Adjust missing-response-components, warn on misplaced response components #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
aj-stein-gsa
force-pushed
the
939-fix-missing-response-components
branch
from
e3eb37a to
862630e
Compare
aj-stein-gsa
force-pushed
the
939-fix-missing-response-components
branch
from
862630e to
1e461ff
Compare
Co-authored-by: Kylie Hunter <[email protected]>
Gabeblis
requested changes
Dec 6, 2024
src/validations/constraints/content/ssp-control-implementation-status-VALID.xml
Show resolved
Hide resolved
aj-stein-gsa
requested review from
kyhu65867,
Gabeblis and
a team
and removed request for
kyhu65867
aj-stein-gsa
dismissed
kyhu65867’s stale review
Feedback addressed, this reviewer is out of office for a few days.
Gabeblis
approved these changes
Dec 13, 2024
|
Good stuff! |
wandmagic
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This is take three after #952 and wandmagic#18. This tweaks missing-response-components and adds another with
level="WARN"just to be clear general NIST practice won't work with FedRAMP.All Submissions:
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated?Bug fix for constraint(s) already spec'ed and documented.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.