-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
931 Connection Security for Network Component #938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes to get the tests passing so we can open this for review 😄
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple suggestions for improvement.
6625c35
to
9bcc47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😄 I'd just make sure the necessary documentation gets added.
5c8e7fa
5c8e7fa
to
3cb6101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, woops, just kidding (I am sorry to reverse course quickly): it seems I missed some changes, should @name="interconnection-security"
not be @name="connection-security"
per the requirements in #931?
@brian-ruf, I know the old way was
|
@GSA/fedramp-oscal-contributors should I add remarks to this constraint to describe that nuance of communication across the boundary? |
cb88e85
to
86ec51d
Compare
Updated PR title, relevant documentation PR has been merged. |
4ce7874
to
b5e5b51
Compare
61f8b48
to
3e1b54a
Compare
7687c9c
to
23a5449
Compare
23a5449
to
72d26f5
Compare
… work because I am still figuring out oscal syntax
Committer Notes
This is a draft. I may need some help tomorrow figuring out if there is a connection security property or if it should be "interconnection security"
Addresses issue #931
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.