Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation point constraint #936

Merged
merged 17 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Examples:
| leveraged-authorization-nature-of-agreement |
| marking |
| missing-response-components |
| network-component-has-implementation-point |
| party-has-name |
| privilege-level |
| prop-response-point-has-cardinality-one |
Expand Down Expand Up @@ -307,6 +308,8 @@ Examples:
| marking-PASS.yaml |
| missing-response-components-FAIL.yaml |
| missing-response-components-PASS.yaml |
| network-component-has-implementation-point-FAIL.yaml |
| network-component-has-implementation-point-PASS.yaml |
| party-has-name-FAIL.yaml |
| party-has-name-PASS.yaml |
| privilege-level-FAIL.yaml |
Expand Down
18 changes: 17 additions & 1 deletion src/validations/constraints/content/ssp-all-VALID.xml
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,23 @@
<p>This is the primary application server for the system.</p>
</remarks>
</component>

<component uuid="66666666-0000-4000-9000-000000000007" type="service">
<title>Firebase CLI Connection</title>
<description>
<p>CLI for updating firebase Secure connection to an external API for data enrichment.</p>
</description>
<prop name="interconnection-security" value="vpn" ns="https://fedramp.gov/ns/oscal"/>
<prop name="interconnection-direction" value="in/out" ns="https://fedramp.gov/ns/oscal"/>
<prop name="asset-type" value="cli"/>
<prop name="implementation-point" value="external"></prop>
wandmagic marked this conversation as resolved.
Show resolved Hide resolved
<status state="operational"/>
<responsible-role role-id="system-admin">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-role>
<remarks>
<p>This connection is used for secure data exchange with external systems.</p>
</remarks>
</component>
<component uuid="6ac88fd2-7c7b-4357-af2e-f22ccd3ead26" type="system">
<title>An External Leveraged System</title>
<description>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://csrc.nist.gov/ns/oscal/1.0 https://github.com/usnistgov/OSCAL/releases/download/v1.1.2/oscal_ssp_schema.xsd"
uuid="12345678-1234-4321-8765-123456789012">
<system-implementation>
<component uuid="66666666-0000-4000-9000-000000000006" type="service">
wandmagic marked this conversation as resolved.
Show resolved Hide resolved
<title>Firebase CLI Connection</title>
<description>
<p>CLI for updating firebase Secure connection to an external API for data enrichment.</p>
</description>
<prop name="asset-type" value="cli"/>
wandmagic marked this conversation as resolved.
Show resolved Hide resolved
<status state="operational"/>
</component>

</system-implementation>
</system-security-plan>
10 changes: 10 additions & 0 deletions src/validations/constraints/fedramp-external-constraints.xml
Original file line number Diff line number Diff line change
Expand Up @@ -553,4 +553,14 @@
</is-unique>
</constraints>
</context>
<context>
<metapath target="//system-implementation"/>
<constraints>
<expect id="network-component-has-implementation-point" target="." test="every $c in component[@type='service' or (@type='software' and ./prop[@name='asset-type' and @value='cli'])] satisfies count($c/prop[@name='implementation-point']) = 1" level="ERROR">
<formal-name>Component Has Implementation Point</formal-name>
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
wandmagic marked this conversation as resolved.
Show resolved Hide resolved
<message>Service components and CLI software components MUST have exactly one implementation-point property.</message>
wandmagic marked this conversation as resolved.
Show resolved Hide resolved
</expect>
</constraints>
</context>
</metaschema-meta-constraints>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for network-component-has-implementation-point
description: >-
This test case validates the behavior of constraint
network-component-has-implementation-point
content: ../content/ssp-network-component-has-implementation-point-INVALID.xml
expectations:
- constraint-id: network-component-has-implementation-point
result: fail
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for network-component-has-implementation-point
description: >-
This test case validates the behavior of constraint
network-component-has-implementation-point
content: ../content/ssp-all-VALID.xml
expectations:
- constraint-id: network-component-has-implementation-point
result: pass
Loading