-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prepared By
Constraints
#870
Conversation
src/validations/constraints/content/ssp-responsible-party-prepared-by-INVALID.xml
Outdated
Show resolved
Hide resolved
...validations/constraints/content/ssp-responsible-party-prepared-by-location-valid-INVALID.xml
Show resolved
Hide resolved
8ee9553
to
4b65ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you address the updated AC requirements in the issue? Sorry again.
Resolved here: 75317f8. I added the check for an embedded address assembly in the party and I added another |
...validations/constraints/content/ssp-responsible-party-prepared-by-location-valid-VALID-1.xml
Show resolved
Hide resolved
...validations/constraints/content/ssp-responsible-party-prepared-by-location-valid-INVALID.xml
Show resolved
Hide resolved
7854335
to
ec5e39a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, I'm okay with this PR, but we need to determine if we're going to require a country code for locations / addresses. Perhaps that can be addressed separately from this PR?
...validations/constraints/content/ssp-responsible-party-prepared-by-location-valid-INVALID.xml
Show resolved
Hide resolved
For context, one of the other checks for country code is too aggressive and that should be rolled back anyway, I think. So that is why I have not brought it up in this PR yet. |
@aj-stein-gsa @Rene2mt I just opened #885 to address the issue with the country-code checks being too broad in the |
ec5e39a
to
7332cb6
Compare
Committer Notes
Purpose
This PR introduces three constraints aimed at ensuring FedRAMP compliance for the digital authorization package by verifying the
prepared-by
roles/parties. These constraints ensure that all required elements are present and that necessary information is accurately documented.Changes
Constraint:
role-defined-prepared-by
Constraint:
responsible-party-prepared-by
Constraint:
responsible-party-prepared-by-location-valid
Tests
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.