Add ADR for constraint-based help documentation by URL for SARIF-based results output #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
requested review from
brian-ruf,
Rene2mt,
wandmagic,
kyhu65867,
david-waltermire and
Gabeblis
aj-stein-gsa
commented
Sep 27, 2024
aj-stein-gsa
commented
Sep 27, 2024
aj-stein-gsa
commented
Sep 27, 2024
5 tasks
aj-stein-gsa
force-pushed
the
720-docs-adr-metapath-sarif-help-url
branch
from
92af1a9 to
fd63316
Compare
5 tasks
Co-authored-by: David Waltermire <[email protected]>
aj-stein-gsa
added a commit
to aj-stein-gsa/metaschema-modules
that referenced
this pull request
Sep 30, 2024
Follow on from relevant discussion that started in metaschema-framework/metaschema-java#131 (comment) as inspired by GSA/fedramp-automation#735.
5 tasks
Rene2mt
previously approved these changes
Sep 30, 2024
Gabeblis
previously approved these changes
Sep 30, 2024
kyhu65867
requested changes
Sep 30, 2024
kyhu65867
previously approved these changes
Sep 30, 2024
Co-authored-by: Gabeblis <[email protected]>
aj-stein-gsa
force-pushed
the
720-docs-adr-metapath-sarif-help-url
branch
from
e395c10 to
f79bfe6
Compare
Per valid PR feedback, we should clarify that AJ and the team drafted and reviewed the PR ahead of soliciting community review and feedback.
david-waltermire
previously approved these changes
Oct 1, 2024
Co-authored-by: David Waltermire <[email protected]>
1 task
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
…d results output (GSA#735) * [skip ci] Start up ADR 9 from template for GSA#720 * [skip ci] Add context for decision in GSA#720 * [skip ci] Add possible solutions for GSA#720 * [skip ci] Hyperlink oscal-cli for bg in GSA#720 PR * [skip ci] Fix Metachema->Metaschema typos for GSA#720 * [skip ci] Add consequences of decisions for GSA#720 * [skip ci] Spacing and style guide for S4 in GSA#720 * [skip ci] Recommend Solution 4 for GSA#720 * [skip ci] Reorg and improve decision rec for GSA#720 * [skip ci] Missed or required for decision in GSA#720 * [skip ci] Clarify backporting and new dev for GSA#720 * [skip ci] Clarify Metaschema data-types and structure per out-of-band PR review * [skip ci] Correct namespace per PR feedbacm. Co-authored-by: David Waltermire <[email protected]> * [skip ci] Correct grammar, editing-edit per review Co-authored-by: Gabeblis <[email protected]> * [skip ci] Clarify team vetted ahead of community Per valid PR feedback, we should clarify that AJ and the team drafted and reviewed the PR ahead of soliciting community review and feedback. * [skip ci] Add newlines for `help-markdown` per final feedback Co-authored-by: David Waltermire <[email protected]> --------- Co-authored-by: David Waltermire <[email protected]> Co-authored-by: Kylie Hunter <[email protected]> Co-authored-by: Gabeblis <[email protected]>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Create an ADR as one of the first steps in #720.
All Submissions:
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated?N/A, because significant documentation improves will follow in follow-on issues and their respective PRs.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.