Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSP metadata system-poc-technical role #687

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Sep 11, 2024

Committer Notes

I'm not sure about this system-poc-technical role. I couldn't find in anywhere in documentation.
I found <responsible-party role-id="system-poc-technical">, but not <role id="system-poc-technical">.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner September 11, 2024 21:02
@DimitriZhurkin
Copy link
Author

To add, I found <role id="system-poc-technical"> in rev 4.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have consulted with @DimitriZhurkin on this PR and I too do not have a clear understanding of whether stakeholders, internal to FR or in the public, need or even just want this data. The legacy Rev 4 PDF documentation discusses the need, but without any explanation. I will finalize a review after I hear back from some stakeholders to adjust this PR to WARNING (if wanted, not needed), merge with ERROR classification if necessary, but more realistically drop it if neither pending the expected feedback on this. For the latter I will just close it and won't merge.

@aj-stein-gsa
Copy link
Contributor

Still need to follow up with review team staff internally. Will post an update later today, tomorrow in the worst case.

@aj-stein-gsa aj-stein-gsa changed the title Add SSP metadata system-poc-technical role [DONOTMERGE] Add SSP metadata system-poc-technical role Sep 18, 2024
@aj-stein-gsa aj-stein-gsa force-pushed the feature/add-system-poc-technical-role branch 3 times, most recently from 627c572 to 9185cd5 Compare September 18, 2024 14:03
@aj-stein-gsa aj-stein-gsa force-pushed the feature/add-system-poc-technical-role branch from 9185cd5 to b79b282 Compare September 18, 2024 14:06
aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 18, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is good with internal review teams as a necessary requirement and should be an earily fast error. Let's hold this until we merge the document updates in GSA/automate.fedramp.gov#57 though.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops left comment not just approval. Let's hold for GSA/automate.fedramp.gov#57 though.

@aj-stein-gsa
Copy link
Contributor

Per discussion with internal staff on the documentation PR associated with this effort, but we will no longer require this roles be added in the present and future requirements for FedRAMP OSCAL SSPs. See this comment and cross-referenced in GSA/automate.fedramp.gov#60 (review). I am closing this PR. @DimitriZhurkin, you can make this constraint in the tracker and GitHub issues as WONTFIX.

@aj-stein-gsa aj-stein-gsa changed the title [DONOTMERGE] Add SSP metadata system-poc-technical role Add SSP metadata system-poc-technical role Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants