Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle base64 filename and media type constraints #681

Conversation

wandmagic
Copy link
Collaborator

Committer Notes

introduce two constraints for //backmatter/resource/base64 node
check for filename and file type

Making this a draft for now so we can discuss if we would like to verify that we have a valid media type, but it works for just assuring that something is there.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd ask you to hold off on this one, the spreadsheet will not have a lot of detail, so I would read the comment here and the linked issue beneath it.

#644 (comment)

I don't think we have clear answers to a better requirement here or I would have kept it going and asked for more review.

@aj-stein-gsa
Copy link
Contributor

I keep forgetting this one has been put on pause, I am going to close it so I do not keep forgetting and coming back to review it. Sorry for the mixup, @wandmagic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants