Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema check failures for Revision 4 content templates #672

Closed
wants to merge 1 commit into from
Closed

Fix schema check failures for Revision 4 content templates #672

wants to merge 1 commit into from

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Sep 10, 2024 •
edited
Loading

Committer Notes

Resolves #668.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa self-assigned this Sep 10, 2024
@aj-stein-gsa aj-stein-gsa force-pushed the 668-description-and-other-assemblies-in-rev-4-content-templates-invalid-to-schema branch from bc7d932 to 3da8cfc Compare September 10, 2024 15:14
@aj-stein-gsa aj-stein-gsa changed the base branch from master to develop September 10, 2024 15:39
@aj-stein-gsa aj-stein-gsa force-pushed the 668-description-and-other-assemblies-in-rev-4-content-templates-invalid-to-schema branch from 3da8cfc to d868448 Compare September 10, 2024 15:48
@aj-stein-gsa
Fix placeholder ... in descriptions for GSA#668
b2f5113 
The `...` syntax is popular for XSpec output in testing to say 'I want
to test the structure but don't care about the specific text value' or
attribute value. Our modern tooling doesn't understand that anyway, so I
am not clear given its generated schema checks with the new tooling.

This commit tests for that.
@aj-stein-gsa aj-stein-gsa force-pushed the 668-description-and-other-assemblies-in-rev-4-content-templates-invalid-to-schema branch from d868448 to b2f5113 Compare September 10, 2024 15:49
@aj-stein-gsa
Copy link
Contributor Author

Sigh, this is a little bit frustrating, it seems these errors pop up because the feature/external-constraints branch is slightly behind and needs to to be rebased off of develop anyway. So b2f51134591ac4c612f1d9239dd6db64ae6c455e do essentially nothing. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aj-stein-gsa aj-stein-gsa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description and other assemblies in Rev 4 content templates invalid to schema
1 participant
@aj-stein-gsa