Fix CI/CD flakiness with docker compose command style update #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
commented
Sep 10, 2024
More details about GHA runner compatibility with old versus new docker compose commands in this discussion post. https://github.com/orgs/community/discussions/27185
Not all, but many, actions were pinned to old versions by tag and to an explicit SHA1 hash from the repo that are old enough to cause GHA error notices. Upgraded from these to current SHA1 hash for the most (692973e3d937129bcbf40652eb9f2f61becf3332) for recent v4.1.7 release. > The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ > The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ Source: https://github.com/GSA/fedramp-automation/actions/runs/10783353551
This directive is now obsolete, causes more noise in the GHA workflow run logs. https://forums.docker.com/t/docker-compose-yml-version-is-obsolete/141313
aj-stein-gsa
force-pushed
the
643-content-processing-cicd-is-flaky
branch
from
92a8552 to
e4461b7
Compare
And fixed, moving back from draft to ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
More details about GHA runner compatibility with old versus new docker compose commands in this discussion post. May resolve #643.
https://github.com/orgs/community/discussions/27185
All Submissions:
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.