Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

980 last accessed #1029

Merged
merged 12 commits into from
Dec 30, 2024
Merged

980 last accessed #1029

merged 12 commits into from
Dec 30, 2024

Conversation

kyhu65867
Copy link

@kyhu65867 kyhu65867 commented Dec 23, 2024

Committer Notes

Addresses issue 980.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate of the file declarations, you may need to add the constraint ID (itself, last-accessed-is-datetime, observe not with the file names) and re-run. It is possible you are failing on coverage? You can see some examples lower in this file.

I am going to test this now locally.

@kyhu65867 kyhu65867 marked this pull request as ready for review December 23, 2024 22:43
@kyhu65867 kyhu65867 requested a review from a team as a code owner December 23, 2024 22:43
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording change, and I am then completely happy with it until we sort out the docs.

@kyhu65867 kyhu65867 requested a review from a team December 26, 2024 13:35
Gabeblis
Gabeblis previously approved these changes Dec 26, 2024
@Gabeblis Gabeblis changed the title 980 last accessed [DO NOT MERGE] 980 last accessed Dec 26, 2024
@Gabeblis
Copy link
Contributor

Looks really good! I'll reapprove when the documentation is added 😄

@aj-stein-gsa aj-stein-gsa self-requested a review December 26, 2024 14:07
@Gabeblis Gabeblis linked an issue Dec 26, 2024 that may be closed by this pull request
14 tasks
@kyhu65867
Copy link
Author

@Gabeblis @aj-stein-gsa I have added a documentation pull request here if you want to take a look: https://github.com/GSA/automate.fedramp.gov/pull/142/files

@Gabeblis Gabeblis changed the title [DO NOT MERGE] 980 last accessed 980 last accessed Dec 29, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyhu65867 kyhu65867 merged commit 23e21e0 into GSA:develop Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for optional last accessed date for referenced resources
3 participants