Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint 'authentication-method-has-remarks' #943

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR introduces a constraint authentication-method-has-remarks, which ensures that every authentication-method property in components dealing with leveraged systems, interconnections, and authorized services includes a remarks field.

Changes

Added Constraint:

  • authentication-method-has-remarks: Validates that every authentication-method property includes a remarks field.

Test Data:

  • Invalid Test Data File: Demonstrates the case where a component's authentication-method count differs from the remarks field count.

Added YAML Files

  • 2 YAML Files: Included pass and fail YAML files to validate the constraint:

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 27, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 27, 2024 12:02
@Gabeblis Gabeblis linked an issue Nov 27, 2024 that may be closed by this pull request
14 tasks
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Blocking]: the ssp-all-VALID.xml should be updated so that it passes this constraint

@Gabeblis
Copy link
Contributor Author

[Blocking]: the ssp-all-VALID.xml should be updated so that it passes this constraint

ssp-all-VALID.xml already has the correct data to satisfy this constraint so I didn't need to make any changes to that file.
This is lines 322-326:

<prop ns="https://fedramp.gov/ns/oscal" name="authentication-method" value="yes">
        <remarks>
          <p>Some description of the authentication method.</p>
        </remarks>
      </prop>

@Gabeblis Gabeblis requested a review from Rene2mt November 27, 2024 16:21
@Rene2mt Rene2mt merged commit 0e5f9c0 into GSA:develop Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each networked component must document its authentication method with remarks
4 participants