Added system-characteristics 'categorization-has constraints and tests

GSA · Sep 10, 2024 · bec0eb1 · bec0eb1
1 parent 9bf9f0c
commit bec0eb1
Show file tree

Hide file tree

Showing 7 changed files with 56 additions and 1 deletion.
diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature
@@ -21,6 +21,10 @@ Examples:
   | attachment-type-PASS.yaml |
   | authorization-type-FAIL.yaml |
   | authorization-type-PASS.yaml |
+  | categorization-has-correct-system-attribute-FAIL.yaml |
+  | categorization-has-correct-system-attribute-PASS.yaml |
+  | categorization-has-information-type-id-FAIL.yaml |
+  | categorization-has-information-type-id-PASS.yaml |
   | cloud-service-model-FAIL.yaml |
   | cloud-service-model-PASS.yaml |
   | component-type-FAIL.yaml |
@@ -61,6 +65,8 @@ Examples:
   | address-type |
   | attachment-type |
   | authorization-type |
+  | categorization-has-correct-system-attribute |
+  | categorization-has-information-type-id |
   | cloud-service-model |
   | component-type |
   | control-implementation-status |

diff --git a/src/validations/constraints/content/ssp-all-INVALID.xml b/src/validations/constraints/content/ssp-all-INVALID.xml
@@ -67,7 +67,7 @@
           <p>Contains sensitive financial data related to organizational operations.</p>
         </description>
         <categorization system="https://unsupported-system.com">
-          <information-type-id>C.2.8.12</information-type-id>
+          <!-- Removed information-type-id to ensure that categorization-has-information-type-id fails correctly. -->
         </categorization>
         <confidentiality-impact>
           <base>high</base>

diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml
@@ -19,4 +19,17 @@
              </remarks>
         </constraints>
 </context>
+
+<context>
+    <metapath target="/system-security-plan"/>
+
+    <constraints>
+        <expect id="categorization-has-correct-system-attribute" target="//system-characteristics" test="system-information/information-type/categorization/@system eq 'https://doi.org/10.6028/NIST.SP.800-60v2r1'" level="ERROR">
+            <message>A FedRAMP SSP information-type categorization lacks a correct system attribute. The correct value is "https://doi.org/10.6028/NIST.SP.800-60v2r1".</message>
+        </expect>
+        <expect id="categorization-has-information-type-id" target="//system-characteristics" test="system-information/information-type/categorization/information-type-id" level="ERROR">
+            <message>A FedRAMP SSP information type categorization must have at least one information type identifier.</message>
+        </expect>
+    </constraints>
+</context>
 </metaschema-meta-constraints>
diff --git a/src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-FAIL.yaml b/src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-FAIL.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for categorization-has-correct-system-attribute
+  description: >-
+    This test case validates the behavior of constraint
+    categorization-has-correct-system-attribute
+  content: ../content/ssp-all-INVALID.xml
+  expectations:
+    - constraint-id: categorization-has-correct-system-attribute
+      result: fail
diff --git a/src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-PASS.yaml b/src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-PASS.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for categorization-has-correct-system-attribute
+  description: >-
+    This test case validates the behavior of constraint
+    categorization-has-correct-system-attribute
+  content: ../content/ssp-all-VALID.xml
+  expectations:
+    - constraint-id: categorization-has-correct-system-attribute
+      result: pass
diff --git a/src/validations/constraints/unit-tests/categorization-has-information-type-id-FAIL.yaml b/src/validations/constraints/unit-tests/categorization-has-information-type-id-FAIL.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for categorization-has-information-type-id
+  description: >-
+    This test case validates the behavior of constraint
+    categorization-has-information-type-id
+  content: ../content/ssp-all-INVALID.xml
+  expectations:
+    - constraint-id: categorization-has-information-type-id
+      result: fail
diff --git a/src/validations/constraints/unit-tests/categorization-has-information-type-id-PASS.yaml b/src/validations/constraints/unit-tests/categorization-has-information-type-id-PASS.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for categorization-has-information-type-id
+  description: >-
+    This test case validates the behavior of constraint
+    categorization-has-information-type-id
+  content: ../content/ssp-all-VALID.xml
+  expectations:
+    - constraint-id: categorization-has-information-type-id
+      result: pass