Skip to content

Commit

Permalink
deprecate ssp-all-valid
Browse files Browse the repository at this point in the history
  • Loading branch information
wandmagic committed Dec 4, 2024
1 parent 9a8e155 commit 46b1102
Show file tree
Hide file tree
Showing 124 changed files with 1,371 additions and 128 deletions.
3 changes: 0 additions & 3 deletions features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ Scenario Outline: Documents that should be valid are pass
Examples:
| valid_file |
| ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml |
# | ssp-all-VALID.xml |
# | ../../../content/awesome-cloud/xml/AwesomeCloudSSP1.xml |
# | ../../../content/awesome-cloud/xml/AwesomeCloudSSP2.xml |

@full-coverage
Scenario: Preparing constraint coverage analysis
Expand Down
4 changes: 2 additions & 2 deletions src/validations/constraints/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,15 @@ npm run constraint
You can add a constraint and test to this repository by following these high-level steps.

1. Create a new constraint in [the appropriate constraints file](#which-constraint-file-do-i-edit). Note the `id`, you will use it later.
2. Add the necessary, correct data to [`./content/ssp-all-VALID.xml`](./content/ssp-all-VALID.xml) for a positive test of the constraint.
2. Add the necessary, correct data to [`../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml`](../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml) for a positive test of the constraint.
3. Add the YAML metadata for the positive test in [`./unit-tests`](./unit-tests/). The name of the file should start with the name of the assembly, field, or flag, and end with `-PASS.yaml`. For example, a new constraint and test for a [`//metadata/party/prop`](https://pages.nist.gov/OSCAL-Reference/models/v1.1.2/system-security-plan/json-reference/#/system-security-plan/metadata/parties) assembly should be `party-PASS.yaml`. The content should be like the example below.

```yaml
# ./unit-tests/party-PASS.yaml
test-case:
name: Positive Test for party
description: This test case validates the behavior of constraint party
content: ../content/ssp-all-VALID.xml
content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
expectations:
- constraint-id: party
result: pass
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
<description>
<p>A diagram-specific explanation.</p>
</description>
<link href="./ssp-all-VALID.xml" rel="diagram"/>
<link href="https://www.fedramp.gov/assets/resources/documents/Agency-Authorization-Auth-Boundary-Diagram-Job-Aid.pdf" rel="diagram"/>
<caption>Authorization Boundary Diagram</caption>
</diagram>
</authorization-boundary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
<description>
<p>A diagram-specific explanation.</p>
</description>
<link href="./ssp-all-VALID.xml" rel="diagram"/>
<link href="https://www.fedramp.gov/assets/resources/documents/Agency-Authorization-Auth-Boundary-Diagram-Job-Aid.pdf" rel="diagram" />
<caption>Data Flow Diagram</caption>
</diagram>
</data-flow>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@
<responsible-party role-id="system-owner">
<party-uuid>22222222-0000-4000-9000-000000000002</party-uuid>
</responsible-party>
<responsible-party role-id="authorizing-official">
<party-uuid>22222222-0000-4000-9000-000000000002</party-uuid>
</responsible-party>
<responsible-party role-id="authorizing-official-poc">
<party-uuid>22222222-0000-4000-9000-000000000002</party-uuid>
</responsible-party>
Expand Down Expand Up @@ -181,7 +178,7 @@
<description>
<p>A diagram-specific explanation.</p>
</description>
<link href="./ssp-all-VALID.xml" rel="diagram"/>
<link href="https://www.fedramp.gov/assets/resources/documents/Agency-Authorization-Auth-Boundary-Diagram-Job-Aid.pdf" rel="diagram"/>
<caption>Network Diagram</caption>
</diagram>
</network-architecture>
Expand Down Expand Up @@ -234,7 +231,7 @@
<description>
<p>Secure connection to an external API for data enrichment.</p>
</description>
<prop name="interconnection-security" value="vpn" ns="https://fedramp.gov/ns/oscal"/>
<prop name="connection-security" value="vpn" ns="https://fedramp.gov/ns/oscal"/>
<prop name="interconnection-direction" value="in/out" ns="https://fedramp.gov/ns/oscal"/>
<status state="operational"/>
<responsible-role role-id="system-admin">
Expand Down
Loading

0 comments on commit 46b1102

Please sign in to comment.